Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 542B6C388F9 for ; Thu, 19 Nov 2020 19:06:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69BB4221FC for ; Thu, 19 Nov 2020 19:06:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XBjmVOvb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69BB4221FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfpGV-00027B-2I for qemu-devel@archiver.kernel.org; Thu, 19 Nov 2020 14:06:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfpFm-0001g5-Ub for qemu-devel@nongnu.org; Thu, 19 Nov 2020 14:05:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:26560) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kfpFg-0000Zr-VJ for qemu-devel@nongnu.org; Thu, 19 Nov 2020 14:05:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605812750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=diI3fDqLsFkXXLMsl4QHLsqt6NuTlso/LgnDPKSfop4=; b=XBjmVOvbPCebOpQNPep+jXZAuBh8Frb/+K0iAhrNlY1EIw9vuRyT+tWn+jVsVW5SK/7g4i eY8JUT869QXXg2b0E5RcXgdHRZR50xPLrHXnC/KtAwyCR2ON+pgAOzEgXfx/EL8HTuzvD4 8BClcFHrkwtGjHRViUprheGAmIWasEA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-KxQ9kDF-NbahampP7AAcqA-1; Thu, 19 Nov 2020 14:05:48 -0500 X-MC-Unique: KxQ9kDF-NbahampP7AAcqA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B469801B13 for ; Thu, 19 Nov 2020 19:05:48 +0000 (UTC) Received: from localhost (ovpn-115-101.rdu2.redhat.com [10.10.115.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id A236D5C1D1; Thu, 19 Nov 2020 19:05:47 +0000 (UTC) Date: Thu, 19 Nov 2020 14:05:46 -0500 From: Eduardo Habkost To: Paolo Bonzini Subject: Re: [PATCH v2 0/8] qom: Use qlit to represent property defaults Message-ID: <20201119190546.GA1509407@habkost.net> References: <20201116224143.1284278-1-ehabkost@redhat.com> <87eekpbjvt.fsf@dusky.pond.sub.org> <20201119171342.GT1509407@habkost.net> <981fb59f-ad67-886c-40e7-6f129997f4c7@redhat.com> <20201119175531.GU1509407@habkost.net> <201edbb0-843d-9be0-af94-cd50d8771a49@redhat.com> MIME-Version: 1.0 In-Reply-To: <201edbb0-843d-9be0-af94-cd50d8771a49@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , Markus Armbruster , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Nov 19, 2020 at 07:25:15PM +0100, Paolo Bonzini wrote: > On 19/11/20 18:55, Eduardo Habkost wrote: > > On Thu, Nov 19, 2020 at 06:23:30PM +0100, Paolo Bonzini wrote: > > > On 19/11/20 18:13, Eduardo Habkost wrote: > > > > > What's left? > > > > Enums. Enums properties are a mess to implement, and I plan to > > > > tackle them later. > > > > > > > > On all other cases, the external representation of the property > > > > value is similar to the internal representation. In the case of > > > > enums, the external representation is a string, but the internal > > > > representation is an integer. > > > > > > > > > > I would have expected a string QLit to work with enums, is there a reason > > > why it doesn't? > > > > It would work, but it would be more inconvenient for callers. > > Right now they use the C enum constant instead of a string. > > It matches what you have to do already for compat props, so it's not a big > deal. I would say just use strings. No problem to me. I'll do. -- Eduardo