Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76D2FC6379F for ; Thu, 19 Nov 2020 21:11:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47F672225E for ; Thu, 19 Nov 2020 21:11:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727007AbgKSVLQ (ORCPT ); Thu, 19 Nov 2020 16:11:16 -0500 Received: from mx2.suse.de ([195.135.220.15]:35910 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726417AbgKSVLQ (ORCPT ); Thu, 19 Nov 2020 16:11:16 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E5F80ABF4; Thu, 19 Nov 2020 21:11:14 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id B4C79DA701; Thu, 19 Nov 2020 22:09:28 +0100 (CET) Date: Thu, 19 Nov 2020 22:09:28 +0100 From: David Sterba To: Qu Wenruo Cc: linux-btrfs@vger.kernel.org, Nikolay Borisov Subject: Re: [PATCH v2 15/24] btrfs: extent-io: make type of extent_state::state to be at least 32 bits Message-ID: <20201119210928.GP20563@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Qu Wenruo , linux-btrfs@vger.kernel.org, Nikolay Borisov References: <20201113125149.140836-1-wqu@suse.com> <20201113125149.140836-16-wqu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201113125149.140836-16-wqu@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, Nov 13, 2020 at 08:51:40PM +0800, Qu Wenruo wrote: > Currently we use 'unsigned' for extent_state::state, which is only ensured > to be at least 16 bits. > > But for incoming subpage support, we are going to introduce more bits, > thus we will go beyond 16 bits. > > To support this, make extent_state::state at least 32bit and to be more > explicit, we use "u32" to be clear about the max supported bits. > > This doesn't increase the memory usage for x86_64, but may affect other > architectures. > > Reviewed-by: Nikolay Borisov > Signed-off-by: Qu Wenruo Added to misc-next.