Content-Type: multipart/mixed; boundary="===============5383355366427339823==" MIME-Version: 1.0 From: Andrew Lunn To: kbuild-all@lists.01.org Subject: Re: [PATCH v10 2/4] net: phy: Add 5GBASER interface mode Date: Fri, 20 Nov 2020 01:55:38 +0100 Message-ID: <20201120005538.GY1804098@lunn.ch> In-Reply-To: List-Id: --===============5383355366427339823== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Fri, Nov 20, 2020 at 10:25:33AM +1000, Pavana Sharma wrote: > Add 5GBASE-R phy interface mode > = > Signed-off-by: Pavana Sharma > --- > include/linux/phy.h | 5 +++++ > 1 file changed, 5 insertions(+) > = > diff --git a/include/linux/phy.h b/include/linux/phy.h > index eb3cb1a98b45..71e280059ec5 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -106,6 +106,7 @@ extern const int phy_10gbit_features_array[1]; > * @PHY_INTERFACE_MODE_TRGMII: Turbo RGMII > * @PHY_INTERFACE_MODE_1000BASEX: 1000 BaseX > * @PHY_INTERFACE_MODE_2500BASEX: 2500 BaseX > + * @PHY_INTERFACE_MODE_5GBASER: 5G BaseR > * @PHY_INTERFACE_MODE_RXAUI: Reduced XAUI > * @PHY_INTERFACE_MODE_XAUI: 10 Gigabit Attachment Unit Interface > * @PHY_INTERFACE_MODE_10GBASER: 10G BaseR > @@ -137,6 +138,8 @@ typedef enum { > PHY_INTERFACE_MODE_TRGMII, > PHY_INTERFACE_MODE_1000BASEX, > PHY_INTERFACE_MODE_2500BASEX, > + /* 5GBASE-R mode */ > + PHY_INTERFACE_MODE_5GBASER, Again, what is the value of the comment? 10GBASE-R has a comment because it is different from the rest, XFI and SFI caused a of discussion, and it was used wrong. But there does not seem to be anything special for 5GBASE-R. Andrew --===============5383355366427339823==--