Content-Type: multipart/mixed; boundary="===============5321234251766010300==" MIME-Version: 1.0 From: Andrew Lunn To: kbuild-all@lists.01.org Subject: Re: [PATCH v10 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int Date: Fri, 20 Nov 2020 01:59:51 +0100 Message-ID: <20201120005951.GZ1804098@lunn.ch> In-Reply-To: List-Id: --===============5321234251766010300== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > @@ -459,7 +459,7 @@ static int mv88e6xxx_port_set_cmode(struct mv88e6xxx_= chip *chip, int port, > chip->ports[port].cmode =3D cmode; > = > lane =3D mv88e6xxx_serdes_get_lane(chip, port); > - if (!lane) > + if (lane < 0) > return -ENODEV; return lane since lane is an errno. Other than that: Reviewed-by: Andrew Lunn Andrew --===============5321234251766010300==--