From: Arnaud Patard (Rtp) Date: Fri, 20 Nov 2020 14:24:27 +0100 Subject: [patch v3 6/9] rockchip: pwm: Fix default polarity References: <20201120132421.500365403@rtp-net.org> Message-ID: <20201120132823.910975188@rtp-net.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In the code, the default polarity is set to positive/positive, which is neither normal polarity or inverted polarity. It's only the hardware default. This leads to booting linux with wrong polarity setting. Update the code to use PWM_DUTY_POSTIVE | PWM_INACTIVE_NEGATIVE by default instead. Signed-off-by: Arnaud Patard Index: u-boot/drivers/pwm/rk_pwm.c =================================================================== --- u-boot.orig/drivers/pwm/rk_pwm.c +++ u-boot/drivers/pwm/rk_pwm.c @@ -146,7 +146,7 @@ static int rk_pwm_probe(struct udevice * priv->data = (struct rockchip_pwm_data *)dev_get_driver_data(dev); if (priv->data->supports_polarity) - priv->conf_polarity = PWM_DUTY_POSTIVE | PWM_INACTIVE_POSTIVE; + priv->conf_polarity = PWM_DUTY_POSTIVE | PWM_INACTIVE_NEGATIVE; return 0; }