Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3316C2D0E4 for ; Mon, 23 Nov 2020 18:22:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D48E20BED for ; Mon, 23 Nov 2020 18:22:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ew2+DT4l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D48E20BED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khGU1-0001jF-9s for qemu-devel@archiver.kernel.org; Mon, 23 Nov 2020 13:22:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khGSN-0000UY-W5 for qemu-devel@nongnu.org; Mon, 23 Nov 2020 13:20:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48086) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1khGSK-000307-7k for qemu-devel@nongnu.org; Mon, 23 Nov 2020 13:20:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606155649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JWkqEhuHoQW3rZOr8MWgwicB9xTuDmx1fnCrO+YDtRY=; b=ew2+DT4l4vyOfDLF792wsHLu7uFjLhU+xNi3+YPROd6qHVxpMg97ZgMRzwHs622rDY02hl i94uyM6gm1zv7D5KxsvCHW5vxLd+reUtD7WBPDUGaoE/XLC95qdmUW2Eg9aSBLZRHajN3S dPJwGKNgsSQVRa4qsD1fmgQ1gFF25uM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-445-7qLtnRkrNymJx6eez6pfUQ-1; Mon, 23 Nov 2020 13:20:46 -0500 X-MC-Unique: 7qLtnRkrNymJx6eez6pfUQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 34EF410151E7; Mon, 23 Nov 2020 18:20:44 +0000 (UTC) Received: from localhost (unknown [10.10.67.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC07360C61; Mon, 23 Nov 2020 18:20:39 +0000 (UTC) Date: Mon, 23 Nov 2020 13:20:38 -0500 From: Eduardo Habkost To: Claudio Fontana Subject: Re: [RFC v3 8/9] module: introduce MODULE_INIT_ACCEL_CPU Message-ID: <20201123182038.GI2271382@habkost.net> References: <20201118220750.GP1509407@habkost.net> <2984625a-15ee-f638-b1bb-050a4514bade@suse.de> <20201120171942.GA2271382@habkost.net> <20201120180936.GD2271382@habkost.net> <3e8fac27-aea5-5f5d-5421-291df660a586@suse.de> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Stefano Stabellini , Paul Durrant , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Jason Wang , Marcelo Tosatti , Richard Henderson , qemu-devel@nongnu.org, Peter Xu , Bruce Rogers , Roman Bolshakov , Wenchao Wang , haxm-team@intel.com, Cameron Esfahani , Anthony Perard , Paolo Bonzini , Sunil Muthuswamy , Dario Faggioli , Olaf Hering , Colin Xu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Nov 23, 2020 at 04:02:24PM +0100, Claudio Fontana wrote: > On 11/23/20 2:18 PM, Paolo Bonzini wrote: > > On 23/11/20 10:55, Claudio Fontana wrote: > >> One idea that came to mind is, why not extend accel.h to user mode? > >> > >> It already contains > >> > >> #ifndef CONFIG_USER_ONLY > >> > >> parts, so maybe it was meant to be used by both, and just happened to > >> end up confined to include/softmmu ? > >> > >> Basically I was thinking, we could have an AccelState and an > >> AccelClass for user mode as well (without bringing in the whole > >> machine thing), and from there we could use current_accel() to build > >> up the right name for the chosen accelerator? > > > > Yes, extending the accelerator class to usermode emulation is certainly > > a good idea. > > > > Paolo > > > > Thanks, I'll work on this option. > > Btw considering that CpusAccel for tcg is actually three different interfaces (for mttcg, for icount, and plain RR), > it will be tough to, in the stated objective, "remove all conditionals", even after removing the tcg_enabled(). The main issue were the conditionals inside module init function. They are completely OK inside accel-specific methods. > > I wonder how you see this issue (patches for 3 TCG split are in Richard's queue atm). > > static void tcg_accel_cpu_init(void) > { > if (tcg_enabled()) { > TCGState *s = TCG_STATE(current_accel()); > > if (s->mttcg_enabled) { > cpus_register_accel(&tcg_cpus_mttcg); > } else if (icount_enabled()) { > cpus_register_accel(&tcg_cpus_icount); > } else { > cpus_register_accel(&tcg_cpus_rr); > } > } > } Probably what we are missing here is a non-softmmu-specific AccelClass.init() method? -- Eduardo