Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71AF9C2D0E4 for ; Mon, 23 Nov 2020 18:26:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3C812080A for ; Mon, 23 Nov 2020 18:26:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JgEM5oVS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3C812080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khGXT-0005Fy-Rg for qemu-devel@archiver.kernel.org; Mon, 23 Nov 2020 13:26:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khGVv-0003kF-RM for qemu-devel@nongnu.org; Mon, 23 Nov 2020 13:24:35 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:37295) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1khGVt-0004Hk-PI for qemu-devel@nongnu.org; Mon, 23 Nov 2020 13:24:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606155872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bKodNDsW/68V3kh1UOToDN8x5ai57T/qLVH2MV4hoos=; b=JgEM5oVSLMGw9OWvEZ9KF58eINewIyHUIn8UlD4RYXmencFN+oRchEQUVBgWPwVWqNbX4h n7FcES9jnkm28oYDH4GqvI99na/lJH66K4YNUR3sIlQ+bo3Kc4angi/OK0LAjECdz+c3CH f/IW2fg6IBgBwdBsZTXDPjw0LlqVpi8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-26-X4DX1COJPUahQjyzbmjlLQ-1; Mon, 23 Nov 2020 13:24:31 -0500 X-MC-Unique: X4DX1COJPUahQjyzbmjlLQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C701E1009462; Mon, 23 Nov 2020 18:24:28 +0000 (UTC) Received: from localhost (unknown [10.10.67.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6A49F5D705; Mon, 23 Nov 2020 18:24:25 +0000 (UTC) Date: Mon, 23 Nov 2020 13:24:20 -0500 From: Eduardo Habkost To: Claudio Fontana Subject: Re: [RFC v3 9/9] i386: split cpu accelerators from cpu.c Message-ID: <20201123182420.GJ2271382@habkost.net> References: <20201118102936.25569-1-cfontana@suse.de> <20201118102936.25569-10-cfontana@suse.de> <20201118182845.GN1509407@habkost.net> <5f6c7b5c-a48a-019d-2646-d0670aeb46e1@suse.de> <20201119192305.GB1509407@habkost.net> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Stefano Stabellini , Paul Durrant , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Jason Wang , Marcelo Tosatti , Richard Henderson , qemu-devel@nongnu.org, Peter Xu , Dario Faggioli , Roman Bolshakov , Wenchao Wang , haxm-team@intel.com, Cameron Esfahani , Anthony Perard , Paolo Bonzini , Sunil Muthuswamy , Bruce Rogers , Olaf Hering , Colin Xu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Nov 20, 2020 at 10:08:46AM +0100, Claudio Fontana wrote: > On 11/19/20 8:23 PM, Eduardo Habkost wrote: > > On Thu, Nov 19, 2020 at 09:53:09AM +0100, Claudio Fontana wrote: > >> Hi, > >> > >> On 11/18/20 7:28 PM, Eduardo Habkost wrote: > >>> On Wed, Nov 18, 2020 at 11:29:36AM +0100, Claudio Fontana wrote: > >>>> split cpu.c into: > >>>> > >>>> cpu.c cpuid and common x86 cpu functionality > >>>> host-cpu.c host x86 cpu functions and "host" cpu type > >>>> kvm/cpu.c KVM x86 cpu type > >>>> hvf/cpu.c HVF x86 cpu type > >>>> tcg/cpu.c TCG x86 cpu type > >>>> > >>>> The accel interface of the X86CPUClass is set at MODULE_INIT_ACCEL_CPU > >>>> time, when the accelerator is known. > >>>> > >>>> Signed-off-by: Claudio Fontana > >>>> --- > >>> [...] > >>>> +/** > >>>> + * X86CPUAccel: > >>>> + * @name: string name of the X86 CPU Accelerator > >>>> + * > >>>> + * @common_class_init: initializer for the common cpu > >>> > >>> So this will be called for every single CPU class. > >> > >> Not really, it's called for every TYPE_X86_CPU cpu class (if an accel interface is registered). > > > > This means every single non-abstract CPU class in > > qemu-system-x86_64, correct? > > > >> > >> This function extends the existing x86_cpu_common_class_init (target/i386/cpu.c), > >> where some methods of the base class CPUClass are set. > >> > >>> > >>>> + * @instance_init: cpu instance initialization > >>>> + * @realizefn: realize function, called first in x86 cpu realize > >>>> + * > >>>> + * X86 CPU accelerator-specific CPU initializations > >>>> + */ > >>>> + > >>>> +struct X86CPUAccel { > >>>> + const char *name; > >>>> + > >>>> + void (*common_class_init)(X86CPUClass *xcc); > >>>> + void (*instance_init)(X86CPU *cpu); > >>>> + void (*realizefn)(X86CPU *cpu, Error **errp); > >>>> }; > >>>> > >>>> +void x86_cpu_accel_init(const X86CPUAccel *accel); > >>> [...] > >>>> +static void x86_cpu_accel_init_aux(ObjectClass *klass, void *opaque) > >>>> +{ > >>>> + X86CPUClass *xcc = X86_CPU_CLASS(klass); > >>>> + const X86CPUAccel **accel = opaque; > >>>> + > >>>> + xcc->accel = *accel; > >>>> + xcc->accel->common_class_init(xcc); > >>>> +} > >>>> + > >>>> +void x86_cpu_accel_init(const X86CPUAccel *accel) > >>>> +{ > >>>> + object_class_foreach(x86_cpu_accel_init_aux, TYPE_X86_CPU, false, &accel); > >>>> +} > >>> > >>> This matches the documented behavior. > >>> > >>> [...] > >>>> +void host_cpu_class_init(X86CPUClass *xcc) > >>>> +{ > >>>> + xcc->host_cpuid_required = true; > >>>> + xcc->ordering = 8; > >>>> + xcc->model_description = > >>>> + g_strdup_printf("%s processor with all supported host features ", > >>>> + xcc->accel->name); > >>>> +} > >>> [...] > >>>> +static void hvf_cpu_common_class_init(X86CPUClass *xcc) > >>>> +{ > >>>> + host_cpu_class_init(xcc); > >>> > >>> Why are you calling host_cpu_class_init() for all CPU types? > >> > >> I am not.. > > > > I don't get it. You are calling host_cpu_class_init() for every > > single non-abstract TYPE_X86_CPU subclass (which includes all CPU > > models in qemu-system-x86_64), and I don't understand why, or if > > this is really intentional. > > It is really intentional what is done here, > > when HVF accelerator is enabled, and only when the HVF accelerator is enabled, > > all X86 CPU classes and subclasses (cpu models, which have been > implemented as subclasses of TYPE_X86_CPU), are updated with a > link to the accelerator-specific HVF interface. I'm confused. That (updating the class with a link) is not what host_cpu_class_init() does. This is what host_cpu_class_init() does: void host_cpu_class_init(X86CPUClass *xcc) { xcc->host_cpuid_required = true; xcc->ordering = 8; xcc->model_description = g_strdup_printf("%s processor with all supported host features ", xcc->accel->name); } Why do you want to call host_cpu_class_init() for every non-abstract TYPE_X86_CPU subclass? -- Eduardo