Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7F6FC2D0E4 for ; Mon, 23 Nov 2020 18:35:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27D922078E for ; Mon, 23 Nov 2020 18:35:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VzIb4z6x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27D922078E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khGgo-0007o3-Qx for qemu-devel@archiver.kernel.org; Mon, 23 Nov 2020 13:35:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khGfE-0006zn-Hg for qemu-devel@nongnu.org; Mon, 23 Nov 2020 13:34:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:29163) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1khGf9-0007li-M8 for qemu-devel@nongnu.org; Mon, 23 Nov 2020 13:34:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606156442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ANzBjtrD/yDxk8eMPNaS1VNoRhLA8yVKN03fPX0swYY=; b=VzIb4z6xGHd/UHhKfVTESt7XIly+VAeP8RpONUrK2E7CxzqcnxAihDyhDP7dl2Ges9M5X3 7Y7bHp1lh31Af0BEGw8rcfdZfruCOF0kl4UVw6Z4Humr+11htRK3RgJdgFjhPEpE3tUDYb aXmOGdaRUcxXNrKOSg2WWUpRyf7MviM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-214-CYr2YTVqORmr6X8W-BbRmg-1; Mon, 23 Nov 2020 13:34:00 -0500 X-MC-Unique: CYr2YTVqORmr6X8W-BbRmg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 32D68100A60A; Mon, 23 Nov 2020 18:33:59 +0000 (UTC) Received: from localhost (unknown [10.10.67.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id D268413470; Mon, 23 Nov 2020 18:33:58 +0000 (UTC) Date: Mon, 23 Nov 2020 13:33:57 -0500 From: Eduardo Habkost To: Markus Armbruster Subject: Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals Message-ID: <20201123183357.GK2271382@habkost.net> References: <20201116224143.1284278-1-ehabkost@redhat.com> <20201116224143.1284278-4-ehabkost@redhat.com> <20201117144246.GD1235237@habkost.net> <87mtzdd4p7.fsf@dusky.pond.sub.org> <20201119182158.GX1509407@habkost.net> <877dqg8ukz.fsf@dusky.pond.sub.org> <20201120182720.GF2271382@habkost.net> <877dqcwlxc.fsf@dusky.pond.sub.org> MIME-Version: 1.0 In-Reply-To: <877dqcwlxc.fsf@dusky.pond.sub.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , QEMU Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Nov 23, 2020 at 08:51:27AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Fri, Nov 20, 2020 at 06:29:16AM +0100, Markus Armbruster wrote: > [...] > >> When the structure of a data type is to be kept away from its users, I > >> prefer to keep it out of the public header, so the compiler enforces the > >> encapsulation. > > > > I prefer that too, except that it is impossible when users of the > > API need the compiler to know the struct size. > > There are cases where the structure of a data type should be > encapsulated, yet its size must be made known for performance (avoid > dynamic memory allocation and pointer chasing). > > Need for encapsulation correlates with complex algorithms and data > structures. The cost of dynamic allocation is often in the noise then. I don't know what we are talking about anymore. None of this applies to the QNum API, right? QNum/QNumValue are not complex data structures, and the reason we need the compiler to know the size of QNumValue is not related to performance at all. We might still want to discourage users of the QNum API from accessing QNum.u/QNumValue.u directly. Documenting the field as private is a very easy way to do it. -- Eduardo