Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F12B6C63777 for ; Tue, 24 Nov 2020 17:58:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BE3B2087C for ; Tue, 24 Nov 2020 17:58:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UYBnA1wn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BE3B2087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khcaM-0002A5-QU for qemu-devel@archiver.kernel.org; Tue, 24 Nov 2020 12:58:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khcYs-00016A-3w for qemu-devel@nongnu.org; Tue, 24 Nov 2020 12:57:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:32079) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1khcYm-0007sk-Sk for qemu-devel@nongnu.org; Tue, 24 Nov 2020 12:57:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606240619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E3xRnxDRx2Kw+NvDOXZOnL7MKFFPmdG3cNAUX5KJFPE=; b=UYBnA1wnk3jMGt1x+bp/EeEz2dCVk3OmAdmKBUsVEvII2tpHlK0SoPYVBJk9WBzcMmuL5N bJ+Rla8f1fFVfmlgG055IzibDnDDPgs1RyjnQzPZwUoGSF4Kl7BntUs3BLiwM8xqpZ2hpf w55d2wx7aU8E1LRvdRJt5Aocw+/Nzks= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-OsrX9S78OGKhZhJgGjdxzg-1; Tue, 24 Nov 2020 12:56:58 -0500 X-MC-Unique: OsrX9S78OGKhZhJgGjdxzg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D19391005D54; Tue, 24 Nov 2020 17:56:55 +0000 (UTC) Received: from localhost (unknown [10.10.67.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A66E60BE5; Tue, 24 Nov 2020 17:56:52 +0000 (UTC) Date: Tue, 24 Nov 2020 12:56:51 -0500 From: Eduardo Habkost To: Claudio Fontana Subject: Re: [RFC v5 08/12] accel: extend AccelState and AccelClass to user-mode Message-ID: <20201124175651.GU2271382@habkost.net> References: <20201124162210.8796-1-cfontana@suse.de> <20201124162210.8796-9-cfontana@suse.de> MIME-Version: 1.0 In-Reply-To: <20201124162210.8796-9-cfontana@suse.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Jason Wang , qemu-devel@nongnu.org, Peter Xu , haxm-team@intel.com, Colin Xu , Olaf Hering , Stefano Stabellini , Bruce Rogers , "Emilio G . Cota" , Anthony Perard , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Laurent Vivier , Thomas Huth , Richard Henderson , Cameron Esfahani , Dario Faggioli , Roman Bolshakov , Sunil Muthuswamy , Marcelo Tosatti , Wenchao Wang , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Nov 24, 2020 at 05:22:06PM +0100, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > --- [...] > @@ -908,8 +909,12 @@ int main(int argc, char **argv) > } > > /* init tcg before creating CPUs and to get qemu_host_page_size */ > - tcg_exec_init(0); > + { > + AccelClass *ac = accel_find("tcg"); > > + g_assert(ac != NULL); > + ac->init_machine(NULL); Most init_machine() methods will crash if you call them with a NULL argument. This looks like another reason for having a void accel_init(AccelState*) function and a void (*init)(AccelState*) method in AccelClass. Then the whole code block above would be as trivial as: accel_init(current_accel()); > + } [...] > -- Eduardo