Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F576C63798 for ; Fri, 27 Nov 2020 13:45:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B60E2224C for ; Fri, 27 Nov 2020 13:45:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B60E2224C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E0256ED18; Fri, 27 Nov 2020 13:45:14 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id F31FB6ED18 for ; Fri, 27 Nov 2020 13:45:12 +0000 (UTC) IronPort-SDR: Mx36WLxzwvykoEfUux1EBt1dtmse6DKrYm1F2xffJf2MwnlfV2E5g3V3DLQWwpHzbqbQcuWtdD 7+yQMBrCWy2Q== X-IronPort-AV: E=McAfee;i="6000,8403,9817"; a="169834598" X-IronPort-AV: E=Sophos;i="5.78,374,1599548400"; d="scan'208";a="169834598" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2020 05:45:11 -0800 IronPort-SDR: IGL96JV7yPgirrWftrgSo7FilDHELao2t+AEo6jQQjPRIobRZOz6Gua9xE3SpcyE4slm40NneX q1LjDqMfZeAA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,374,1599548400"; d="scan'208";a="333690227" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga006.jf.intel.com with SMTP; 27 Nov 2020 05:45:08 -0800 Received: by stinkbox (sSMTP sendmail emulation); Fri, 27 Nov 2020 15:45:08 +0200 Date: Fri, 27 Nov 2020 15:45:08 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Uma Shankar Message-ID: <20201127134508.GL6112@intel.com> References: <20201126210314.7882-1-uma.shankar@intel.com> <20201126210314.7882-9-uma.shankar@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201126210314.7882-9-uma.shankar@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [v12 08/15] drm/i915/display: Enable colorspace programming for LSPCON devices X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Nov 27, 2020 at 02:33:07AM +0530, Uma Shankar wrote: > Enable HDMI Colorspace for LSPCON based devices. Sending Colorimetry > data for HDR using AVI infoframe. LSPCON firmware expects this and though > SOC drives DP, for HDMI panel AVI infoframe is sent to the LSPCON device > which transfers the same to HDMI sink. > = > v2: Dropped state managed in drm core as per Jani Nikula's suggestion. > = > v3: Aligned colorimetry handling for lspcon as per compute_avi_infoframes, > as suggested by Ville. > = > v4: Finally fixed this with Ville's help, re-phrased the commit header > and description. Still missing the "expose the hdmi variant of the prop on lspcon" part. I didn't include that in my patch since we didn't use drm_hdmi_avi_infoframe_colorspace() yes on lspcon. Although maybe I should have just done that change anyway since we were already registering the prop anyway even if we didn't actually put the data into the infoframe. > = > Credits-to: Ville Syrj=E4l=E4 > Signed-off-by: Uma Shankar > --- > drivers/gpu/drm/i915/display/intel_lspcon.c | 3 +++ > 1 file changed, 3 insertions(+) > = > diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/dr= m/i915/display/intel_lspcon.c > index 0a4c05d67108..cb768a1ae4c9 100644 > --- a/drivers/gpu/drm/i915/display/intel_lspcon.c > +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c > @@ -523,6 +523,9 @@ void lspcon_set_infoframes(struct intel_encoder *enco= der, > else > frame.avi.colorspace =3D HDMI_COLORSPACE_RGB; > = > + /* Set the Colorspace as per the HDMI spec */ > + drm_hdmi_avi_infoframe_colorspace(&frame.avi, conn_state); > + > /* nonsense combination */ > drm_WARN_ON(encoder->base.dev, crtc_state->limited_color_range && > crtc_state->output_format !=3D INTEL_OUTPUT_FORMAT_RGB); > -- = > 2.26.2 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx