Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 203ABC2D0E4 for ; Fri, 27 Nov 2020 15:19:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0E9722228 for ; Fri, 27 Nov 2020 15:19:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="ljeX4APN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0E9722228 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B85926EE31; Fri, 27 Nov 2020 15:19:24 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 24F746EE31 for ; Fri, 27 Nov 2020 15:19:24 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id s8so5924934wrw.10 for ; Fri, 27 Nov 2020 07:19:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Oycry3K1WhhTZ7hEJqA9SAwvS/LmKXcuYv7oms1gtCU=; b=ljeX4APNPETLCWhmW1cQPjGhB/6JwdsWTw2uG+XXGCIjJ5ryWKwD5S9LT/rAYxku5P Vq2mp9ZgbsRtOFeUCO8Gt8tqtYVvAvmy8z7iXYB7WDI2T9JwsyHOYGE1yuBvnI+aedpx XqNnIPw5705PiIlx5mpx3K6HQnFQqg7xX/cco= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Oycry3K1WhhTZ7hEJqA9SAwvS/LmKXcuYv7oms1gtCU=; b=DgQ3w7mxerWnyGNNfz6zzNWcwFti08PPY4ymqvzGRqFER80ydDAD9CF+UMPPgqRViK 5qSJOqhdLha2eH7nW/22wDGx/u2YE7uewCNJ6dpp3OhR8P2aAJLyt8Uc/o64TiuGsSvI ZGlVPtmHrxvtcuAYGjd/yordjreV3NGf6rotlJTON8zCAWhC/4GZ0zCGsBvr56CprFbr clkN+gtGO0VHTBe+PFVEZCVVSvLLvSZoIVRvcHtccZdlHjBcT2xiAGHysXi/271J2gzr Q/WReZ7R+PY+3WnP6US6iQ7t6g6+O04gCDxIJRhR74hW6O5WFXjdpWPaafjiB52+XqCO maAg== X-Gm-Message-State: AOAM5339RVmLoODseIE6xKgwMkuiUKKviDzAoQvGf5mwQkAMgkMUoxqL 2v9E1r76BeNuQEQhV51btYmWuA== X-Google-Smtp-Source: ABdhPJxS6iZnYG6feLSYwTnrKKH98Taizf34WyRG9MRuJuW5ymtgnuvEvZ9XqWnj/sCM9DBL7rwafg== X-Received: by 2002:a5d:4141:: with SMTP id c1mr5275228wrq.80.1606490362845; Fri, 27 Nov 2020 07:19:22 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id l14sm13461420wmi.33.2020.11.27.07.19.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 07:19:22 -0800 (PST) Date: Fri, 27 Nov 2020 16:19:20 +0100 From: Daniel Vetter To: Imre Deak Subject: Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color Message-ID: <20201127151920.GI401619@phenom.ffwll.local> References: <20201123182631.1740781-1-imre.deak@intel.com> <20201127143100.GB2144692@ideak-desk.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201127143100.GB2144692@ideak-desk.fi.intel.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nanley Chery , Jani Nikula , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rafael Antognolli , Dhinakaran Pandiyan , Kalyan Kondapally Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Nov 27, 2020 at 04:31:00PM +0200, Imre Deak wrote: > Hi Daniel, Jani, > > is it ok to merge this patch along with 2/2 via the i915 tree? Ack from mesa (userspace in general, but mesa is kinda mandatory) is missing I think. With that Acked-by: Daniel Vetter > > --Imre > > On Mon, Nov 23, 2020 at 08:26:30PM +0200, Imre Deak wrote: > > From: Radhakrishna Sripada > > > > Gen12 display can decompress surfaces compressed by render engine with > > Clear Color, add a new modifier as the driver needs to know the surface > > was compressed by render engine. > > > > V2: Description changes as suggested by Rafael. > > V3: Mention the Clear Color size of 64 bits in the comments(DK) > > v4: Fix trailing whitespaces > > v5: Explain Clear Color in the documentation. > > v6: Documentation Nitpicks(Nanley) > > > > Cc: Ville Syrjala > > Cc: Dhinakaran Pandiyan > > Cc: Kalyan Kondapally > > Cc: Rafael Antognolli > > Cc: Nanley Chery > > Signed-off-by: Radhakrishna Sripada > > Signed-off-by: Imre Deak > > --- > > include/uapi/drm/drm_fourcc.h | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > > index ca48ed0e6bc1..0a1b2c4c4bee 100644 > > --- a/include/uapi/drm/drm_fourcc.h > > +++ b/include/uapi/drm/drm_fourcc.h > > @@ -527,6 +527,25 @@ extern "C" { > > */ > > #define I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS fourcc_mod_code(INTEL, 7) > > > > +/* > > + * Intel Color Control Surface with Clear Color (CCS) for Gen-12 render > > + * compression. > > + * > > + * The main surface is Y-tiled and is at plane index 0 whereas CCS is linear > > + * and at index 1. The clear color is stored at index 2, and the pitch should > > + * be ignored. The clear color structure is 256 bits. The first 128 bits > > + * represents Raw Clear Color Red, Green, Blue and Alpha color each represented > > + * by 32 bits. The raw clear color is consumed by the 3d engine and generates > > + * the converted clear color of size 64 bits. The first 32 bits store the Lower > > + * Converted Clear Color value and the next 32 bits store the Higher Converted > > + * Clear Color value when applicable. The Converted Clear Color values are > > + * consumed by the DE. The last 64 bits are used to store Color Discard Enable > > + * and Depth Clear Value Valid which are ignored by the DE. A CCS cache line > > + * corresponds to an area of 4x1 tiles in the main surface. The main surface > > + * pitch is required to be a multiple of 4 tile widths. > > + */ > > +#define I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC fourcc_mod_code(INTEL, 8) > > + > > /* > > * Tiled, NV12MT, grouped in 64 (pixels) x 32 (lines) -sized macroblocks > > * > > -- > > 2.25.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel