Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB48EC63697 for ; Sat, 28 Nov 2020 10:18:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44C4F2227F for ; Sat, 28 Nov 2020 10:18:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cT/4Rdjd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44C4F2227F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=1sK7i71DPnkXpDb3iRbR8BDyAHIokEw2vMzSubKrT3U=; b=cT/4RdjdNTjjkW7/XQb93nTDy4 fxhGBvlhRiHowAjT/M8KQwi0/mIdqiiyI5LL4oNMms9Kj0xX1NZWoe7vztRWYq0BztfHr8FzG8MAc MlXF7006TflbLbZ3T0eOePfzH6WSOz2m8W+eUCAfypFQSIG1mpUV0DSciKUa4y9Apo9TnGjXHrtcP maYDQruvhohLjDE7aLMocn0tSiJ2WVFYtRxO2pulE4H9mo0KIOb9imIT/Z3redjIi/h8T9/i1Ei1L K9vFKi77m0+C/F96AMczItABaCEmXt0UUBYfLW0Qxv4MVVLrmAH76e1Vj1Ao/7Fls15cArivy2dy1 MhYbTsWA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kixHC-0006NO-04; Sat, 28 Nov 2020 10:16:22 +0000 Received: from szxga05-in.huawei.com ([45.249.212.191]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kixH7-0006Me-D2 for linux-arm-kernel@lists.infradead.org; Sat, 28 Nov 2020 10:16:18 +0000 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CjnSL2skKzLv0D; Sat, 28 Nov 2020 18:15:30 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Sat, 28 Nov 2020 18:15:49 +0800 From: Qinglang Miao To: Hyun Kwon , Laurent Pinchart , Mauro Carvalho Chehab , Michal Simek Subject: [PATCH 3/3] media: xilinx: fix error return code in xvip_graph_init Date: Sat, 28 Nov 2020 18:20:02 +0800 Message-ID: <20201128102002.95402-1-miaoqinglang@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201128_051618_294617_48B27F38 X-CRM114-Status: GOOD ( 10.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qinglang Miao , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix to return a negative error code(-ENODEV) from the error handling case instead of 0, as done elsewhere in this function. Fixes: df3305156f98 ("[media] v4l: xilinx: Add Xilinx Video IP core") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/media/platform/xilinx/xilinx-vipp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c index cc2856efe..9cab2f77f 100644 --- a/drivers/media/platform/xilinx/xilinx-vipp.c +++ b/drivers/media/platform/xilinx/xilinx-vipp.c @@ -525,6 +525,7 @@ static int xvip_graph_init(struct xvip_composite_device *xdev) if (list_empty(&xdev->notifier.asd_list)) { dev_err(xdev->dev, "no subdev found in graph\n"); + ret = -ENODEV; goto done; } -- 2.23.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel