Content-Type: multipart/mixed; boundary="===============6932174715974190618==" MIME-Version: 1.0 From: Russell King - ARM Linux admin To: kbuild-all@lists.01.org Subject: Re: [PATCH net-next] net: sfp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 workaround Date: Wed, 02 Dec 2020 13:11:58 +0000 Message-ID: <20201202131158.GK1605@shell.armlinux.org.uk> In-Reply-To: <20201125140020.GJ1551@shell.armlinux.org.uk> List-Id: --===============6932174715974190618== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, Nov 25, 2020 at 02:00:20PM +0000, Russell King - ARM Linux admin wr= ote: > On Tue, Nov 24, 2020 at 08:18:56AM +0800, kernel test robot wrote: > > All warnings (new ones prefixed by >>): > > = > > drivers/net/phy/sfp.c: In function 'sfp_i2c_read': > > >> drivers/net/phy/sfp.c:339:9: warning: variable 'block_size' set but = not used [-Wunused-but-set-variable] > > 339 | size_t block_size; > > | ^~~~~~~~~~ > = > I'm waiting for Thomas to re-test the fixed patch I sent, but Thomas > seems to be of the opinion that there's no need to re-test, despite > the fixed patch having the intended effect of changing the behaviour > on the I2C bus. > = > If nothing is forthcoming, I'm intending to drop the patch; we don't > need to waste time supporting untested workarounds for what are > essentially broken SFPs by vendors twisting the SFP MSA in the > kernel. I have had no further co-operation from Thomas so far. If I don't hear from someone who is able to test this module by this weekend, I will be dropping this patch from my repository. -- = RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! --===============6932174715974190618==--