From: Tom Rini Date: Thu, 3 Dec 2020 11:59:05 -0500 Subject: [PATCH v2] common: update: fix an "unused" warning against update_flash() In-Reply-To: <20201119003719.14186-1-takahiro.akashi@linaro.org> References: <20201119003719.14186-1-takahiro.akashi@linaro.org> Message-ID: <20201203165905.GK32272@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Nov 19, 2020 at 09:37:19AM +0900, AKASHI Takahiro wrote: > Since update_flash() is used only in update_tftp(), it should be > guarded with appropriate config options. > > After the commit 3149e524fc1e, common/update.c will be built under > either CONFIG_UDATE_TFTP, CONFIG_DFU_TFTP or CONFIG_UPDATE_FIT. > Since CONFIG_UPDATE_FIT, hence fit_update(), doesn't rely on > update_flash(), the compiler may cause an "unused" warning if > CONFIG_UPDATE_FIT=y and CONFIG_UPDATE_TFTP=n and CONFIG_DFU_TFTP=n. > > This is, for example, the case for sandbox defconfig where > EFI_CAPSULE_FIRMWARE_FIT is enabled for test purpose. > > Fixes: 3149e524fc1e ("common: update: add a generic interface for FIT > image") > Signed-off-by: AKASHI Takahiro Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: