From: Tom Rini Date: Thu, 3 Dec 2020 11:59:11 -0500 Subject: [PATCH v1] linux/compat.h: Remove debug() from spin_lock_irqsave() In-Reply-To: <20201119192620.54872-1-andriy.shevchenko@linux.intel.com> References: <20201119192620.54872-1-andriy.shevchenko@linux.intel.com> Message-ID: <20201203165911.GL32272@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Nov 19, 2020 at 09:26:20PM +0200, Andy Shevchenko wrote: > It seems nobody tested the debug() option in spin_lock_irqsave(). > Currently, when #define DEBUG, it spoils the compiler with > > In file included from drivers/usb/dwc3/gadget.c:18: > drivers/usb/dwc3/gadget.c: In function ?dwc3_gadget_set_selfpowered?: > include/log.h:235:4: warning: ?flags? is used uninitialized in this function [-Wuninitialized] > 235 | printf(pr_fmt(fmt), ##args); \ > | ^~~~~~ > drivers/usb/dwc3/gadget.c:1347:17: note: ?flags? was declared here > 1347 | unsigned long flags; > | ^~~~~ > > and so on... > Drop useless debug() call to make compiler happy. > > Fixes: 0c06db598367 ("lib, linux: move linux specific defines to linux/compat.h") > Cc: Heiko Schocher > Cc: Tom Rini > Signed-off-by: Andy Shevchenko > Reviewed-by: Oleksandr Andrushchenko > Reviewed-by: Heiko Schocher Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: