Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF895C433FE for ; Fri, 4 Dec 2020 09:12:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 796282255F for ; Fri, 4 Dec 2020 09:12:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 796282255F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F1246E139; Fri, 4 Dec 2020 09:12:37 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 093B56E139; Fri, 4 Dec 2020 09:12:34 +0000 (UTC) IronPort-SDR: PECk7RDdG6b9ExcZ62OfdyQgt4jmMJZYRUZaECY1wgCyCccEYxWA6Dz++3aeX0ZtBXMBJmwqWi F5mcpY8wuF2g== X-IronPort-AV: E=McAfee;i="6000,8403,9824"; a="237466814" X-IronPort-AV: E=Sophos;i="5.78,392,1599548400"; d="scan'208";a="237466814" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2020 01:12:31 -0800 IronPort-SDR: F7a8u65N1OTio2VSueQtq9xXKYXM+JEX4zWZGcd/2awd2sw+/yfnH+q/KtJcxYdU9UHxhGxaM4 cQqxoCFAV+Qg== X-IronPort-AV: E=Sophos;i="5.78,392,1599548400"; d="scan'208";a="373866051" Received: from genxfsim-desktop.iind.intel.com (HELO intel.com) ([10.223.74.178]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2020 01:12:28 -0800 Date: Fri, 4 Dec 2020 14:28:55 +0530 From: Anshuman Gupta To: Ramalingam C Subject: Re: [PATCH v6 04/18] drm/i915/hdcp: No HDCP when encoder is't initialized Message-ID: <20201204085854.GD30377@intel.com> References: <20201126073722.19107-1-anshuman.gupta@intel.com> <20201126073722.19107-5-anshuman.gupta@intel.com> <20201204090216.GA5336@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201204090216.GA5336@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, uma.shankar@intel.com, seanpaul@chromium.org, juston.li@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2020-12-04 at 14:32:16 +0530, Ramalingam C wrote: > On 2020-11-26 at 13:07:08 +0530, Anshuman Gupta wrote: > > There can be situation when DP MST connector is created without > > mst modeset being done, in those cases connector->encoder will be > > NULL. MST connector->encoder initializes after modeset. > > This patch is to reject the HDCP request on MST connector without > encoder initialized(modeset). But userspace are not supposed to request hdcp at such > scenario right?. AFAIU user space doesn't know about DP MST topology until unless it parse PATH property. This crash oberved on chrome OS with DP MST dock. From driver POV it should avoid kernel crash in such cases. Thanks, Anshuman Gupta. > > Ram > > > Don't enable HDCP in such cases to prevent any crash. > > > > Cc: Ramalingam C > > Cc: Juston Li > > Signed-off-by: Anshuman Gupta > > --- > > drivers/gpu/drm/i915/display/intel_hdcp.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c > > index b9d8825e2bb1..7d63e9495956 100644 > > --- a/drivers/gpu/drm/i915/display/intel_hdcp.c > > +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c > > @@ -2106,6 +2106,12 @@ int intel_hdcp_enable(struct intel_connector *connector, > > if (!hdcp->shim) > > return -ENOENT; > > > > + if (!connector->encoder) { > > + drm_err(&dev_priv->drm, "[%s:%d] encoder is not initialized\n", > > + connector->base.name, connector->base.base.id); > > + return -ENODEV; > > + } > > + > > mutex_lock(&hdcp->mutex); > > mutex_lock(&dig_port->hdcp_mutex); > > drm_WARN_ON(&dev_priv->drm, > > -- > > 2.26.2 > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel