Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA08AC433FE for ; Fri, 4 Dec 2020 15:39:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE09022B30 for ; Fri, 4 Dec 2020 15:39:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730491AbgLDPjf (ORCPT ); Fri, 4 Dec 2020 10:39:35 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:38730 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728950AbgLDPje (ORCPT ); Fri, 4 Dec 2020 10:39:34 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1klDAY-00AEK1-Kz; Fri, 04 Dec 2020 16:38:50 +0100 Date: Fri, 4 Dec 2020 16:38:50 +0100 From: Andrew Lunn To: Russell King Cc: Heiner Kallweit , Pali =?iso-8859-1?Q?Roh=E1r?= , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: sfp: relax bitrate-derived mode check Message-ID: <20201204153850.GD2400258@lunn.ch> References: <20201204143451.GL1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Dec 04, 2020 at 02:35:27PM +0000, Russell King wrote: > Do not check the encoding when deriving 1000BASE-X from the bitrate > when no other modes are discovered. Some GPON modules (VSOL V2801F > and CarlitoxxPro CPGOS03-0490 v2.0) indicate NRZ encoding with a > 1200Mbaud bitrate, but should be driven with 1000BASE-X on the host > side. Seems like somebody could make a nice side line writing SFP EEPROM validation tools. There obviously are none in widespread use! Reviewed-by: Andrew Lunn Andrew