Content-Type: multipart/mixed; boundary="===============8465658875188791799==" MIME-Version: 1.0 From: Sam Ravnborg To: kbuild-all@lists.01.org Subject: Re: [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU Date: Sun, 06 Dec 2020 22:48:14 +0100 Message-ID: <20201206214814.GA1884161@ravnborg.org> In-Reply-To: <202012070518.yJA9Vbbo-lkp@intel.com> List-Id: --===============8465658875188791799== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable commit aa1f4345b5480502a4e61addf5c59d606fdbce8f Author: Sam Ravnborg Date: Mon Nov 30 22:09:29 2020 +0100 sh: Fix set but not used warnings with !CONFIG_MMU = Building fbdev drivers for sh with W=3D1 produces the following warning: = tmiofb.c: In function =E2=80=98tmiofb_remove=E2=80=99: tmiofb.c:805:21: warning: variable =E2=80=98par=E2=80=99 set but no= t used = This is with allmodconfig and ARCH=3Dsh = This boiled down to iounmap() defined as empty for !CONFIG_MMU. Fix this by by adding "(void)addr;" to tell the compiler the argument to iounmap() should be considered used. = v4: - Fix build error of ethernet driver (kernel test robot) Added missing () around macro parameter = Signed-off-by: Sam Ravnborg Cc: kernel test robot Cc: Thomas Zimmermann Cc: Lee Jones Cc: Rich Felker Cc: Arnd Bergmann Cc: Geert Uytterhoeven Cc: Mike Rapoport Cc: Kuninori Morimoto Cc: Peter Zijlstra Cc: Sam Ravnborg Cc: Andrew Morton diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h index 6d5c6463bc07..45082bcbd9aa 100644 --- a/arch/sh/include/asm/io.h +++ b/arch/sh/include/asm/io.h @@ -271,7 +271,7 @@ static inline void __iomem *ioremap_prot(phys_addr_t of= fset, unsigned long size, #endif /* CONFIG_HAVE_IOREMAP_PROT */ = #else /* CONFIG_MMU */ -#define iounmap(addr) do { } while (0) +#define iounmap(addr) do { (void)(addr); } while (0) #define ioremap(offset, size) ((void __iomem *)(unsigned long)(offset)) #endif /* CONFIG_MMU */ =20 --===============8465658875188791799==--