Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kmB9y-0004gB-Pu for mharc-grub-devel@gnu.org; Mon, 07 Dec 2020 02:42:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmB9u-0004Ys-Ls for grub-devel@gnu.org; Mon, 07 Dec 2020 02:42:10 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:55731) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmB9o-0007lx-7m for grub-devel@gnu.org; Mon, 07 Dec 2020 02:42:10 -0500 Received: by mail-wm1-x333.google.com with SMTP id x22so10566845wmc.5 for ; Sun, 06 Dec 2020 23:42:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R7ZsrHA/VokvtxARbS4w6ak/k6t/iEHANArvWytKLw4=; b=VQk5vMPMEeM4BYvnH4nn3A9Lb3a0nRNl7fWVT5G5etRKtyF4FgpZt5DOOzGx76stKv RXkogIi3F0nhevTr4hI4KP94pFhAXglh++2hWlRH896E+78qL8DArXsjEGEFaYPyAgCa 3aEj4ORrhiWv42409U3Ii182Fod1dbl4OfOlMpc7o+6neEPJ8BsRXphnWLlm8rlAy3qN YpjlCUYktnkeKXiLdCEPsz33o9do/KsCyozmpeQ1818pzdZ1+7zoCVBmb1tS24m7UBRl ALPC+P1NkDqWihQ1UsMQi5GT6fD+xbSjDQpm1dBjty+XIgXAmVQQDzoyK4woEmAEiic5 mpxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R7ZsrHA/VokvtxARbS4w6ak/k6t/iEHANArvWytKLw4=; b=G41q7gMlZT26ZxwLt5zyvF5DD/drfKx0E+qs3nMvMdROnO5i3Cf/D0c7olnDDFeSFP no1ALiDja1+sN4R2Y+sq5fgo8OREtk6Js6b0clJhDl3GbXtYp0P+TogGil3Ws+ZQDb0A LDvgDkCTIHnuV7NkyV8snlO+XqHWjic/4iUJaNpTUDa0Gl/DS5b1Fewr+dmPOvmLkcvJ alYd/khZjVqPt+UXkPale/x3bT8jQSVkJX/nEtuucHLRbxO34m4HkpGDZeF0MKsqo4Bv +zyyrGxmqJpbtiDPAKwfh+CchIPr3enE+xJXf7yay5JOMFlpXHUU7u5R4Cg9vAXRU3Fg +rOQ== X-Gm-Message-State: AOAM532gkglm99ybl3PxQ/9uKbjnO3QEDLu4iMHlccK7cWjo1j9GALT2 XqHP6+Q5ytEYGimMpMDjTTRKGrQMAArnuenS X-Google-Smtp-Source: ABdhPJzUe8h3ujsRKMq25ZwCkdZSh+Y1Lczf3JgseiFhvstQQIOMSooDqPaG1r0NWOMZdwLVcbdf0A== X-Received: by 2002:a05:600c:210e:: with SMTP id u14mr17156491wml.48.1607326922513; Sun, 06 Dec 2020 23:42:02 -0800 (PST) Received: from rudolphp-notebook.9e.network (b2b-78-94-0-50.unitymedia.biz. [78.94.0.50]) by smtp.gmail.com with ESMTPSA id h83sm13979687wmf.9.2020.12.06.23.42.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 23:42:01 -0800 (PST) From: Patrick Rudolph To: grub-devel@gnu.org Cc: Patrick Rudolph Subject: [PATCH v2 4/7] grub-core/bus/usb: Add function pointer for attach/detach events Date: Mon, 7 Dec 2020 08:41:24 +0100 Message-Id: <20201207074127.59286-5-patrick.rudolph@9elements.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201207074127.59286-1-patrick.rudolph@9elements.com> References: <20201207074127.59286-1-patrick.rudolph@9elements.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=patrick.rudolph@9elements.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2020 07:42:11 -0000 The xHCI code needs to be called for attaching or detaching a device. Introduce two functions pointers and call it from the USB hub code. Will be used in future commits, currently this doesn't change any functionality. Signed-off-by: Patrick Rudolph --- grub-core/bus/usb/ehci.c | 2 ++ grub-core/bus/usb/ohci.c | 2 ++ grub-core/bus/usb/uhci.c | 2 ++ grub-core/bus/usb/usbhub.c | 19 +++++++++++++++++++ include/grub/usb.h | 4 ++++ 5 files changed, 29 insertions(+) diff --git a/grub-core/bus/usb/ehci.c b/grub-core/bus/usb/ehci.c index d966fc210..6b3f2f87a 100644 --- a/grub-core/bus/usb/ehci.c +++ b/grub-core/bus/usb/ehci.c @@ -1812,6 +1812,8 @@ static struct grub_usb_controller_dev usb_controller = { .hubports = grub_ehci_hubports, .portstatus = grub_ehci_portstatus, .detect_dev = grub_ehci_detect_dev, + .attach_dev = NULL, + .detach_dev = NULL, /* estimated max. count of TDs for one bulk transfer */ .max_bulk_tds = GRUB_EHCI_N_TD * 3 / 4 }; diff --git a/grub-core/bus/usb/ohci.c b/grub-core/bus/usb/ohci.c index f0be533d4..44c7e94a9 100644 --- a/grub-core/bus/usb/ohci.c +++ b/grub-core/bus/usb/ohci.c @@ -1440,6 +1440,8 @@ static struct grub_usb_controller_dev usb_controller = .hubports = grub_ohci_hubports, .portstatus = grub_ohci_portstatus, .detect_dev = grub_ohci_detect_dev, + .attach_dev = NULL, + .detach_dev = NULL, /* estimated max. count of TDs for one bulk transfer */ .max_bulk_tds = GRUB_OHCI_TDS * 3 / 4 }; diff --git a/grub-core/bus/usb/uhci.c b/grub-core/bus/usb/uhci.c index 7c5811fd6..4143d24fe 100644 --- a/grub-core/bus/usb/uhci.c +++ b/grub-core/bus/usb/uhci.c @@ -845,6 +845,8 @@ static struct grub_usb_controller_dev usb_controller = .hubports = grub_uhci_hubports, .portstatus = grub_uhci_portstatus, .detect_dev = grub_uhci_detect_dev, + .attach_dev = NULL, + .detach_dev = NULL, /* estimated max. count of TDs for one bulk transfer */ .max_bulk_tds = N_TD * 3 / 4 }; diff --git a/grub-core/bus/usb/usbhub.c b/grub-core/bus/usb/usbhub.c index 136bf6ee4..df1913aee 100644 --- a/grub-core/bus/usb/usbhub.c +++ b/grub-core/bus/usb/usbhub.c @@ -66,6 +66,15 @@ grub_usb_hub_add_dev (grub_usb_controller_t controller, dev->split_hubport = split_hubport; dev->split_hubaddr = split_hubaddr; + if (controller->dev->attach_dev) { + err = controller->dev->attach_dev (controller, dev); + if (err) + { + grub_free (dev); + return NULL; + } + } + err = grub_usb_device_initialize (dev); if (err) { @@ -405,6 +414,8 @@ static void detach_device (grub_usb_device_t dev) { unsigned i; + grub_usb_err_t err; + int k; if (!dev) return; @@ -425,6 +436,14 @@ detach_device (grub_usb_device_t dev) if (inter && inter->detach_hook) inter->detach_hook (dev, i, k); } + if (dev->controller.dev->detach_dev) { + err = dev->controller.dev->detach_dev (&dev->controller, dev); + if (err) + { + // XXX + } + } + grub_usb_devs[dev->addr] = 0; } diff --git a/include/grub/usb.h b/include/grub/usb.h index f65ac4f5d..5c5fb5ec4 100644 --- a/include/grub/usb.h +++ b/include/grub/usb.h @@ -122,6 +122,10 @@ struct grub_usb_controller_dev grub_usb_speed_t (*detect_dev) (grub_usb_controller_t dev, int port, int *changed); + grub_usb_err_t (*attach_dev) (grub_usb_controller_t ctrl, grub_usb_device_t dev); + + grub_usb_err_t (*detach_dev) (grub_usb_controller_t ctrl, grub_usb_device_t dev); + /* Per controller flag - port reset pending, don't do another reset */ grub_uint64_t pending_reset; -- 2.26.2