Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7671FC4361B for ; Mon, 7 Dec 2020 09:24:01 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 174FD2311B; Mon, 7 Dec 2020 09:24:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 174FD2311B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kmCkS-0004WX-9I; Mon, 07 Dec 2020 09:24:00 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmCkP-0004WM-NA for linux-f2fs-devel@lists.sourceforge.net; Mon, 07 Dec 2020 09:23:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/AKw3QAvKEa2lkLil6gYjKY3fePFNHBjlHWonbKaWQk=; b=hMrLfaQelUnSxw+tBSuTspl2QO Mzc3H4NFzOpcEn13O5d2V0PEVUyQD6Dr+zL3TDX1vcFsww1gw94IECH1/2Lk/rskUb7syFL/H2G5H SfrdqtIWNkk1aEUAy4As3tBTOfuLw8OsshkUoWbyqa1mvFiah6HxJgpSe3ivgWGSPmcE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject: To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/AKw3QAvKEa2lkLil6gYjKY3fePFNHBjlHWonbKaWQk=; b=HR1gOZmUHK7tnC0AGT2tYF7l2x K5KJwzulP/Xnr3lWwuUwxUv9Fnv8/Tdtmg76TezfMVZPew5rusQliYeDg1o1+2+F7BwA4+WsqSmx/ TS7U6EXkWIqwZeum/XB+CdyKeYhZZB+w+YtnaPYxVqoF+RhhW5jiJrOcp6FAddX6G6Cg=; Received: from szxga04-in.huawei.com ([45.249.212.190]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kmCkK-001kdY-60 for linux-f2fs-devel@lists.sourceforge.net; Mon, 07 Dec 2020 09:23:57 +0000 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CqHsr5R8dz15Yft for ; Mon, 7 Dec 2020 17:23:12 +0800 (CST) Received: from huawei.com (10.175.101.6) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Mon, 7 Dec 2020 17:23:41 +0800 From: Jack Qiu To: Date: Mon, 7 Dec 2020 18:24:06 +0800 Message-ID: <20201207102407.25154-3-jack.qiu@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201207102407.25154-1-jack.qiu@huawei.com> References: <20201207102407.25154-1-jack.qiu@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.101.6] X-CFilter-Loop: Reflected X-Headers-End: 1kmCkK-001kdY-60 Subject: [f2fs-dev] [PATCH v2 2/3] f2fs: inline: remove redundant FI_DATA_EXIST set X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net FI_DATA_EXIST has been set in recover_inline_flags, no need set in f2fs_recover_inline_data again. Just remove it. Signed-off-by: Jack Qiu --- fs/f2fs/inline.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c index 0399531efcd3..0a8f7eefca7d 100644 --- a/fs/f2fs/inline.c +++ b/fs/f2fs/inline.c @@ -286,7 +286,6 @@ int f2fs_recover_inline_data(struct inode *inode, struct page *npage) memcpy(dst_addr, src_addr, MAX_INLINE_DATA(inode)); set_inode_flag(inode, FI_INLINE_DATA); - set_inode_flag(inode, FI_DATA_EXIST); set_page_dirty(ipage); f2fs_put_page(ipage, 1); -- 2.17.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel