Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 726B8C433FE for ; Mon, 7 Dec 2020 10:25:38 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B2C52311A for ; Mon, 7 Dec 2020 10:25:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B2C52311A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.46127.81828 (Exim 4.92) (envelope-from ) id 1kmDhx-0005xi-Nd; Mon, 07 Dec 2020 10:25:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 46127.81828; Mon, 07 Dec 2020 10:25:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmDhx-0005xb-KV; Mon, 07 Dec 2020 10:25:29 +0000 Received: by outflank-mailman (input) for mailman id 46127; Mon, 07 Dec 2020 10:25:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmDhw-0005xU-B0 for xen-devel@lists.xenproject.org; Mon, 07 Dec 2020 10:25:28 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 81d14cd7-cad1-4b66-b4b9-44ece13be304; Mon, 07 Dec 2020 10:25:25 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-11-VhlrEtJON5GtTXd0WawECg-1; Mon, 07 Dec 2020 05:25:23 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ADC311005513; Mon, 7 Dec 2020 10:25:20 +0000 (UTC) Received: from redhat.com (ovpn-113-137.ams2.redhat.com [10.36.113.137]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6921C60BE2; Mon, 7 Dec 2020 10:25:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81d14cd7-cad1-4b66-b4b9-44ece13be304 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607336725; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lgvE6LyH4jrE6pQS01wyiRU9NGcs0HDZI4+lkUVm7vc=; b=HEhpMnQ+XLIrHO4FWkVVCTFIgHBRpY+s0JhdVTs64XOAWq0nEdzU4lEdnoz/nQ+q6fCaSQ kNVnigQsYBNIz5UAsXCTWaYWDu5YbKZR9LiolZIy8ov4uDKzVqwF30ERJxECHST+FsFhzJ 3d1H1DPIBgLpflcCCgvpzGJ7oKPXgBg= X-MC-Unique: VhlrEtJON5GtTXd0WawECg-1 Date: Mon, 7 Dec 2020 10:25:08 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Peter Maydell , Aleksandar Rikalo , Stefano Stabellini , kvm@vger.kernel.org, Paul Durrant , Cornelia Huck , Marcelo Tosatti , Wainer dos Santos Moschetta , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Paolo Bonzini , Willian Rampazzo , Huacai Chen , Anthony Perard , xen-devel@lists.xenproject.org, David Gibson , Alex =?utf-8?Q?Benn=C3=A9e?= , Aurelien Jarno , Claudio Fontana Subject: Re: [PATCH 5/8] gitlab-ci: Add KVM s390x cross-build jobs Message-ID: <20201207102450.GG3102898@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20201206185508.3545711-1-philmd@redhat.com> <20201206185508.3545711-6-philmd@redhat.com> <66d4d0ab-2bb5-1284-b08a-43c6c30f30dc@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <66d4d0ab-2bb5-1284-b08a-43c6c30f30dc@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 On Mon, Dec 07, 2020 at 06:46:01AM +0100, Thomas Huth wrote: > On 06/12/2020 19.55, Philippe Mathieu-Daudé wrote: > > Cross-build s390x target with only KVM accelerator enabled. > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > .gitlab-ci.d/crossbuilds-kvm-s390x.yml | 6 ++++++ > > .gitlab-ci.yml | 1 + > > MAINTAINERS | 1 + > > 3 files changed, 8 insertions(+) > > create mode 100644 .gitlab-ci.d/crossbuilds-kvm-s390x.yml > > > > diff --git a/.gitlab-ci.d/crossbuilds-kvm-s390x.yml b/.gitlab-ci.d/crossbuilds-kvm-s390x.yml > > new file mode 100644 > > index 00000000000..1731af62056 > > --- /dev/null > > +++ b/.gitlab-ci.d/crossbuilds-kvm-s390x.yml > > @@ -0,0 +1,6 @@ > > +cross-s390x-kvm: > > + extends: .cross_accel_build_job > > + variables: > > + IMAGE: debian-s390x-cross > > + TARGETS: s390x-softmmu > > + ACCEL_CONFIGURE_OPTS: --disable-tcg > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > > index 573afceb3c7..a69619d7319 100644 > > --- a/.gitlab-ci.yml > > +++ b/.gitlab-ci.yml > > @@ -14,6 +14,7 @@ include: > > - local: '/.gitlab-ci.d/crossbuilds.yml' > > - local: '/.gitlab-ci.d/crossbuilds-kvm-x86.yml' > > - local: '/.gitlab-ci.d/crossbuilds-kvm-arm.yml' > > + - local: '/.gitlab-ci.d/crossbuilds-kvm-s390x.yml' > > KVM code is already covered by the "cross-s390x-system" job, but an > additional compilation test with --disable-tcg makes sense here. I'd then > rather name it "cross-s390x-no-tcg" or so instead of "cross-s390x-kvm". > > And while you're at it, I'd maybe rather name the new file just > crossbuilds-s390x.yml and also move the other s390x related jobs into it? I don't think we really should split it up so much - just put these jobs in the existing crosbuilds.yml file. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|