Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8616C433FE for ; Mon, 7 Dec 2020 21:31:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3DBBF22ADF for ; Mon, 7 Dec 2020 21:31:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DBBF22ADF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmO6O-0007KK-5i for qemu-devel@archiver.kernel.org; Mon, 07 Dec 2020 16:31:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmO3g-0006IY-A0 for qemu-devel@nongnu.org; Mon, 07 Dec 2020 16:28:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:56399) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmO3V-0004nm-VM for qemu-devel@nongnu.org; Mon, 07 Dec 2020 16:28:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607376503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LgVP0d+FLAg5wz/5aumgdzP06jtil+1++3XLVONNygo=; b=El/cOgwzUO91tuCMiF0ftBjgXaGH3+zw7bbeDGz7ckWozYaVE5aLeiCjKLf+POZ7lCvylX 6Pok54X/UfwKYvOnZ9MeqSxUoWZ/WKNJwH/iac+ZShkdsXUW0kw9OAed3PyBEl75aOwMgh T0onln+gBhCpu3745/XmSnUr+QUbUS8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-134-vpVb3jkMP0Ollct2A94ajw-1; Mon, 07 Dec 2020 16:28:19 -0500 X-MC-Unique: vpVb3jkMP0Ollct2A94ajw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 575B01005504; Mon, 7 Dec 2020 21:28:15 +0000 (UTC) Received: from localhost (ovpn-120-147.rdu2.redhat.com [10.10.120.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id F076D60BE2; Mon, 7 Dec 2020 21:28:14 +0000 (UTC) Date: Mon, 7 Dec 2020 16:28:14 -0500 From: Eduardo Habkost To: Peter Maydell Subject: Re: [PATCH] target/arm: do not use cc->do_interrupt for KVM directly Message-ID: <20201207212814.GJ1289986@habkost.net> References: <20201207084042.7690-1-cfontana@suse.de> <20201207174916.GD1289986@habkost.net> <20201207182842.GE1289986@habkost.net> <2e2e0160-7c17-cdfd-93e0-3d2002996108@suse.de> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex =?utf-8?Q?Benn=C3=A9e?= , Dongjiu Geng , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Claudio Fontana , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Dec 07, 2020 at 09:12:34PM +0000, Peter Maydell wrote: > On Mon, 7 Dec 2020 at 21:06, Claudio Fontana wrote: > > As I understand it, for the purpose of code separation, > > we could: > > > > 1) skip do_interrupt move to the separate tcg_ops structure, wait until KVM/ARM uses another approach (if ever) > > 2) do the move, and just call arm_cpu_do_interrupt() directly, since for KVM64 it is the only one that can be assigned to cc->do_interrupt(). > > > > Which way would you suggest? > > So what's the intention here? To put tcg-only methods in their > own struct so that on a KVM-only QEMU they're compiled out > and attempts to use them are a compile error? In that case > I guess if Arm really is the only user of do_interrupt outside > TCG then we should do what this patch does and do a direct call. Oh, I thought you were arguing that CPUClass.do_interrupt is not TCG_specific. If you agree with doing what this patch does, the plan sounds good to me. -- Eduardo