From: Hongwei Zhang Date: Mon, 7 Dec 2020 17:40:02 -0500 Subject: [u-boot, v1 0/1] mtd: spi-nor-ids: add Micron MT25QL01G flash In-Reply-To: <20201207224002.24562-1-hongweiz@ami.com> References: <20201204220602.5896-1-hongweiz@ami.com> <20201207224002.24562-1-hongweiz@ami.com> Message-ID: <20201207224002.24562-3-hongweiz@ami.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de >From: Patrice CHOTARD > >Hi Hongwei > >On 12/4/20 11:06 PM, Hongwei Zhang wrote: >> Add STMICRO MT25QL01G flash, used on AST2600 board. > >MT25QL01G is not a STMicroelectronics flash but a Micron one ;-) Thanks for the correction, Patrice. I came back to spi-nor-ids.c, there are two places in the code checking CONFIG_SPI_FLASH_STMICRO define, at line 167 (a lot of Micron flashes included in the block), and at line 239, furthermore, there is no SPI_FLASH_MICRON config menu in Kconfig file. I got confused, why SPI_FLASH_MICRON is not in Kconfig? > >Patrice > >> >> Signed-off-by: Hongwei Zhang >> --- >> drivers/mtd/spi/spi-nor-ids.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mtd/spi/spi-nor-ids.c >> b/drivers/mtd/spi/spi-nor-ids.c index 09e8196048..6d22b80586 100644 >> --- a/drivers/mtd/spi/spi-nor-ids.c >> +++ b/drivers/mtd/spi/spi-nor-ids.c >> @@ -185,6 +185,7 @@ const struct flash_info spi_nor_ids[] = { >> { INFO("n25q512ax3", 0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | >SPI_NOR_QUAD_READ) }, >> { INFO("n25q00", 0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ >| NO_CHIP_ERASE) }, >> { INFO("n25q00a", 0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ >| NO_CHIP_ERASE) }, >> + { INFO("mt25ql01g", 0x21ba20, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | >SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, >> { INFO("mt25qu02g", 0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | >SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },