Content-Type: multipart/mixed; boundary="===============2886038096133664467==" MIME-Version: 1.0 From: Andrew Lunn To: kbuild-all@lists.01.org Subject: Re: [PATCH v11 1/4] dt-bindings: net: Add 5GBASER phy interface mode Date: Thu, 10 Dec 2020 00:15:12 +0100 Message-ID: <20201209231512.GF2649111@lunn.ch> In-Reply-To: <0537d23a6178c8507f3fda2ab8e0140b6117ef74.1607488953.git.pavana.sharma@digi.com> List-Id: --===============2886038096133664467== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, Dec 09, 2020 at 03:03:47PM +1000, Pavana Sharma wrote: > Add 5gbase-r PHY interface mode. > = > Signed-off-by: Pavana Sharma > --- > Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 ++ > 1 file changed, 2 insertions(+) > = > diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.ya= ml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > index fdf709817218..aa6ae7851de9 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > @@ -89,6 +89,8 @@ properties: > - trgmii > - 1000base-x > - 2500base-x > + # 5GBASE-R > + - 5gbase-r > - rxaui > - xaui Hi Pavana For v10 i said: > What value does the comment add? I don't remember you replying. Why is 5gbase-r special and it needs a comment, saying the same thing in CAPS LETTERS? What value is there in the CAPS LETTERS string? Thanks Andrew --===============2886038096133664467==--