Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BC91C4361B for ; Fri, 11 Dec 2020 09:36:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 095EF23F2B for ; Fri, 11 Dec 2020 09:36:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 095EF23F2B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h3L3Voh3sM8XZfGwwJA1EotK0J1ZuJsFYB3Q+l+aRmg=; b=Oyu4R75GuzX75pktcyVXzsdK1 aJnEokoxk/yOlOLvehXfIf4jiCgb2uPTGXXb+NfvEuv/HKGqz9wqKNfCCbLd7oh4gS86I0glLnE+2 F90qP43TJQ60Myl+2K+0S4HBu9Q/vreeP/IrLNwng8o0D45e1Fe2Hk0L13vpLWfo6EFY6yUsrO1Ph jYETtGurPbtCR/nUnNScx86r/kw/nDQmn1sz5G0LgY4w3n2n36MS5S1pcfis2g0ZAmo9xEb5rOGL7 C3WtAaT+p/M16BR13+jTslDPfhcUgsOgpC+AG2NTvSSJsRcVKsH7Vdi3nWWtVF+qPbw3e5h5kvWuY Iq3fkB7sQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1knepR-0008M0-Pm; Fri, 11 Dec 2020 09:35:09 +0000 Received: from r3-18.sinamail.sina.com.cn ([202.108.3.18]) by merlin.infradead.org with smtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1knepM-0008JF-6J for linux-arm-kernel@lists.infradead.org; Fri, 11 Dec 2020 09:35:07 +0000 Received: from unknown (HELO localhost.localdomain)([103.193.190.174]) by sina.com with ESMTP id 5FD33D3B0000280E; Fri, 11 Dec 2020 17:34:53 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 41740815073500 From: Hillf Danton To: Mel Gorman Subject: Re: [PATCH 3/4] sched/fair: Do not replace recent_used_cpu with the new target Date: Fri, 11 Dec 2020 17:34:43 +0800 Message-Id: <20201211093443.3259-1-hdanton@sina.com> In-Reply-To: <20201211090228.GU3371@techsingularity.net> References: <20201208153501.1467-1-mgorman@techsingularity.net> <20201211062542.3082-1-hdanton@sina.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201211_043504_515451_D656DD82 X-CRM114-Status: UNSURE ( 8.50 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juri Lelli , Barry Song , Vincent Guittot , Peter Ziljstra , Aubrey Li , LKML , Ingo Molnar , Valentin Schneider , Linux-ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 11 Dec 2020 09:02:28 +0000 Mel Gorman wrote: >On Fri, Dec 11, 2020 at 02:25:42PM +0800, Hillf Danton wrote: >> On Tue, 8 Dec 2020 15:35:00 +0000 Mel Gorman wrote: >> > @@ -6277,17 +6277,13 @@ static int select_idle_sibling(struct task_struct *p, int prev, int target) >> > >> > /* Check a recently used CPU as a potential idle candidate: */ >> > recent_used_cpu = p->recent_used_cpu; >> > + p->recent_used_cpu = prev; >> > if (recent_used_cpu != prev && >> > recent_used_cpu != target && >> > cpus_share_cache(recent_used_cpu, target) && >> > (available_idle_cpu(recent_used_cpu) || sched_idle_cpu(recent_used_cpu)) && >> > cpumask_test_cpu(p->recent_used_cpu, p->cpus_ptr) && >> >> Typo? Fix it in spin if so. >> > >What typo? After your change it is prev that we check against p->cpus_ptr instead of the recent CPU. Wonder the point to do such a check for returning the recent one. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel