Date: Fri, 11 Dec 2020 10:06:24 -0500 From: Vivek Goyal Message-ID: <20201211150624.GC3285@redhat.com> References: <20201207183021.22752-1-vgoyal@redhat.com> <20201207183021.22752-4-vgoyal@redhat.com> <20201210200303.GN3629@work-vm> <20201210200931.GA185111@redhat.com> <97a0de57-8422-2fdc-e16e-0d6f133f615c@gmail.com> <20201211110522.GB3380@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20201211110522.GB3380@work-vm> Subject: Re: [Virtio-fs] ceph + freeipa ubuntu/fedora common small bug List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: virtio-fs@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org On Fri, Dec 11, 2020 at 11:05:22AM +0000, Dr. David Alan Gilbert wrote: > * Harry G. Coin (hgcoin@gmail.com) wrote: > > FYI.=A0 Same thing we saw on Fedora installing freeipa, this on ubuntu > > with ceph.=A0 Identical bitmask report. > >=20 > > ... > >=20 > > Fixing /var/run/ceph ownership....done > >=20 > > Cannot set file attribute for '/var/log/journal', value=3D0x00800000, > > mask=3D0x00800000, ignoring: Function not implemented > >=20 > > Cannot set file attribute for > > '/var/log/journal/fd007229322043ad8778c214d19ed3ac', value=3D0x00800000, > > mask=3D0x00800000, ignoring: Function not implemented >=20 > This looks like it comes out of systemd's src/tmpfiles/tmpfiles.c: >=20 > r =3D chattr_fd(procfs_fd, f, item->attribute_mask, NULL); > if (r < 0) > log_full_errno(IN_SET(r, -ENOTTY, -EOPNOTSUPP) ? LOG_DEBU= G : LOG_WARNING, > r, > "Cannot set file attribute for '%s', value= =3D0x%08x, mask=3D0x%08x, ignoring: %m", > path, item->attribute_value, item->attribu= te_mask); >=20 > and it's chattr_fd is in it's src/basic/chattr-util.c > which is using FS_IOC_GET/SETFLAGS, which seems to be an older > way of doing things. >=20 > Now, is that supposed to promote itself to a newer call or is it OK? I see that we don't have any ->ioctl function registered in passthrough_ll.c and that's why do_ioctl() (fuse_lowlevel.c) will return -ENOSYS. So we probably need to modify passthrough_ll.c to support some select ioctls. Right now it looks like all fs ioctls will return -ENOSYS. I tried "chattr +i foo.txt" and that return -ENOSYS as well. Vivek