Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA66C2BB48 for ; Mon, 14 Dec 2020 16:22:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10AD722795 for ; Mon, 14 Dec 2020 16:22:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10AD722795 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D7E5D6E32A; Mon, 14 Dec 2020 16:22:39 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E16C6E32A; Mon, 14 Dec 2020 16:22:38 +0000 (UTC) IronPort-SDR: Kec+48/YR1L2fLXlv9wk5xjBi+hDaV+3kDtqTblu3b/t/l+OnrVWrBuvaeMAVpne/Ghv4iP8it TuJhjP/UCRKQ== X-IronPort-AV: E=McAfee;i="6000,8403,9834"; a="193095108" X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="193095108" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 08:22:34 -0800 IronPort-SDR: H+QH7esplQt7GQkr+fZS75FR5nvDwEV2oQHH5F8FcwN5pS+bq/hylqRH1IIOsEzua8kAVP1+E3 8/Sc4BkDMIfQ== X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="367486855" Received: from ideak-desk.fi.intel.com ([10.237.68.141]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 08:22:31 -0800 Date: Mon, 14 Dec 2020 18:22:27 +0200 From: Imre Deak To: "Chery, Nanley G" Subject: Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color Message-ID: <20201214162227.GA3566534@ideak-desk.fi.intel.com> References: <20201123182631.1740781-1-imre.deak@intel.com> <20201127143100.GB2144692@ideak-desk.fi.intel.com> <20201127151920.GI401619@phenom.ffwll.local> <20201127180604.GA2169344@ideak-desk.fi.intel.com> <0048c10f7b8047b18934e730ae57386c@intel.com> <20201201120456.GC2849269@ideak-desk.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Cc: "Nikula, Jani" , Daniel Vetter , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , Chris Wilson , "Pandiyan, Dhinakaran" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Dec 11, 2020 at 09:04:02AM +0200, Chery, Nanley G wrote: > [...] > > > We probably don't have to update the header, but we noticed in our > > > testing that the clear color prefers an alignment greater than 64B. > > > Unfortunately, I can't find any bspec note about this. As long as the > > > buffer creators are aware though, I think we should be fine. I don't > > > know if this is the best forum to bring it up, but I thought I'd > > > share. > > > > Yes, would be good to clarify this and get it also to the spec. Then the > > driver should also check the alignment of the 3rd FB plane. > > I plan to run some more tests and file a bug in the spec. Ok, thanks. Note that this patch has a problem with synchornization and based on Chris' response I'm planning to update it once I figured out the proper way to map the CC plane. Until that you could still use it on TGL if you wait for the RT result explicitly after the fast clear and before flipping to it (that's what the IGT test does atm). > I see that the IGT test only clears the fb once. Just to confirm, is the > clear color offset read from on every frame? Userspace would like to be > able to pass different clear colors for an fb. Yes, every time you do a flip the kernel will re-read the CC value and program it to the display. --Imre _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel