Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAEACC2BBD5 for ; Mon, 14 Dec 2020 17:33:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2738D22C7D for ; Mon, 14 Dec 2020 17:26:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2738D22C7D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1korcQ-0000Zs-LH for qemu-devel@archiver.kernel.org; Mon, 14 Dec 2020 12:26:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koraP-00074s-6S for qemu-devel@nongnu.org; Mon, 14 Dec 2020 12:24:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24197) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1koraN-0001d1-MI for qemu-devel@nongnu.org; Mon, 14 Dec 2020 12:24:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607966674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tVrw542DX2KLO2TPzENouPrv7sTLbHUO9KuI1dV/ApQ=; b=bDXjI4abxFtwdC/tsW2nrfoKnVKVaD8YQsk5TWUNxcatxLh8Zx/c1pZ3TyFBXKwIygRQGL BqULqAv/Rzgjg8ZK+QKwQX+MRzxBzCzK1woMQy0UqjK+WXR6VdMHaM2GWaz17nkHh2CoNO LMdt3ocZ8QryqDiy5hmNtOhsVjihzwU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-583-5mqhwgx1OAqCYa9M4ykgwA-1; Mon, 14 Dec 2020 12:24:31 -0500 X-MC-Unique: 5mqhwgx1OAqCYa9M4ykgwA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E043E107ACF5; Mon, 14 Dec 2020 17:24:28 +0000 (UTC) Received: from localhost (ovpn-116-160.rdu2.redhat.com [10.10.116.160]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6BE2410021AA; Mon, 14 Dec 2020 17:24:19 +0000 (UTC) Date: Mon, 14 Dec 2020 12:24:18 -0500 From: Eduardo Habkost To: Igor Mammedov Subject: Re: [PATCH v4 23/32] qdev: Move dev->realized check to qdev_property_set() Message-ID: <20201214172418.GK1289986@habkost.net> References: <20201211220529.2290218-1-ehabkost@redhat.com> <20201211220529.2290218-24-ehabkost@redhat.com> <20201214155530.55f80cd6@redhat.com> MIME-Version: 1.0 In-Reply-To: <20201214155530.55f80cd6@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthew Rosato , Paul Durrant , Mark Cave-Ayland , qemu-devel@nongnu.org, Stefano Stabellini , qemu-block@nongnu.org, Stefan Berger , David Hildenbrand , Markus Armbruster , Halil Pasic , Christian Borntraeger , Anthony Perard , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Artyom Tarasenko , Thomas Huth , Alex Williamson , xen-devel@lists.xenproject.org, John Snow , Richard Henderson , Kevin Wolf , "Daniel P. Berrange" , Cornelia Huck , qemu-s390x@nongnu.org, Max Reitz , Paolo Bonzini , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Dec 14, 2020 at 03:55:30PM +0100, Igor Mammedov wrote: > On Fri, 11 Dec 2020 17:05:20 -0500 > Eduardo Habkost wrote: > > > Every single qdev property setter function manually checks > > dev->realized. We can just check dev->realized inside > > qdev_property_set() instead. > > > > The check is being added as a separate function > > (qdev_prop_allow_set()) because it will become a callback later. > > is callback added within this series? > and I'd add here what's the purpose of it. It will be added in part 2 of the series. See v3: https://lore.kernel.org/qemu-devel/20201112214350.872250-35-ehabkost@redhat.com/ I don't know what else I could say about its purpose, in addition to what I wrote above, and the comment below[1]. If you are just curious about the callback and confused because it is not anywhere in this series, I can just remove the paragraph above from the commit message. Would that be enough? > [...] > > +/* returns: true if property is allowed to be set, false otherwise */ [1] ^^^ > > +static bool qdev_prop_allow_set(Object *obj, const char *name, > > + Error **errp) > > +{ > > + DeviceState *dev = DEVICE(obj); > > + > > + if (dev->realized) { > > + qdev_prop_set_after_realize(dev, name, errp); > > + return false; > > + } > > + return true; > > +} > > + -- Eduardo