Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1138EC4361B for ; Tue, 15 Dec 2020 15:43:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8BD6224B8 for ; Tue, 15 Dec 2020 15:42:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8BD6224B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpCTa-0005a1-Sa for qemu-devel@archiver.kernel.org; Tue, 15 Dec 2020 10:42:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpCR9-0002IC-Di for qemu-devel@nongnu.org; Tue, 15 Dec 2020 10:40:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:47266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kpCR7-0004l3-F7 for qemu-devel@nongnu.org; Tue, 15 Dec 2020 10:40:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608046824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=esvoYFQPo65/45+omvGrwir4tE/mdnGMw+CkmXgIFX0=; b=BKiHMKl1d+uGp7iRpw40LSccqheOMdw8IstAeYBJWL1YdkcqqnLzUY+fGTnnZyP7QUIqk3 YxEhiE5Sa+d+sn98UzMG5EQwEQnkqQ/MvMH6TD0zKHMA9Fj1Ifm5RqQbdePAfACcK4vNCg tR7rjDrSIChKplAOPQhAAq3nRZJpMNc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-586-thFt9xlnPxaceKL478ck2A-1; Tue, 15 Dec 2020 10:40:20 -0500 X-MC-Unique: thFt9xlnPxaceKL478ck2A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F1A8F180E472; Tue, 15 Dec 2020 15:40:19 +0000 (UTC) Received: from localhost (ovpn-115-226.rdu2.redhat.com [10.10.115.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id EA9B25D9D7; Tue, 15 Dec 2020 15:40:15 +0000 (UTC) Date: Tue, 15 Dec 2020 10:40:15 -0500 From: Eduardo Habkost To: qemu-devel@nongnu.org Subject: Re: [PATCH v4 00/32] qdev property code cleanup Message-ID: <20201215154015.GW1289986@habkost.net> References: <20201211220529.2290218-1-ehabkost@redhat.com> <20201214194238.GP1289986@habkost.net> MIME-Version: 1.0 In-Reply-To: <20201214194238.GP1289986@habkost.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Daniel P. Berrange" , John Snow , Markus Armbruster , Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Igor Mammedov , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Dec 14, 2020 at 02:42:44PM -0500, Eduardo Habkost wrote: > On Fri, Dec 11, 2020 at 05:04:57PM -0500, Eduardo Habkost wrote: > > This code contains the first 32 patches from the series: > > > > Subject: [PATCH v3 00/53] Make qdev static property API usable by any QOM type > > https://lore.kernel.org/qemu-devel/20201112214350.872250-1-ehabkost@redhat.com > > > > I'm submitting this separately so we can merge the qdev-specific > > cleanup while we discuss our long term plans for QOM properties. > > > > Eduardo Habkost (32): > > cs4231: Get rid of empty property array > > cpu: Move cpu_common_props to hw/core/cpu.c > > qdev: Move property code to qdev-properties.[ch] > > qdev: Check dev->realized at set_size() > > sparc: Check dev->realized at sparc_set_nwindows() > > qdev: Don't use dev->id on set_size32() error message > > qdev: Make PropertyInfo.print method get Object* argument > > qdev: Make bit_prop_set() get Object* argument > > qdev: Make qdev_get_prop_ptr() get Object* arg > > qdev: Make qdev_find_global_prop() get Object* argument > > qdev: Make check_prop_still_unset() get Object* argument > > qdev: Make error_set_from_qdev_prop_error() get Object* argument > > qdev: Make qdev_propinfo_get_uint16() static > > qdev: Move UUID property to qdev-properties-system.c > > I'm queueing patches 1-14 (above) on machine-next. > > > qdev: Move softmmu properties to qdev-properties-system.h > > qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macros > > sparc: Use DEFINE_PROP for nwindows property > > qdev: Get just property name at error_set_from_qdev_prop_error() > > qdev: Avoid using prop->name unnecessarily > > qdev: Add name parameter to qdev_class_add_property() > > qdev: Add name argument to PropertyInfo.create method > > qdev: Wrap getters and setters in separate helpers > > qdev: Move dev->realized check to qdev_property_set() > > qdev: Make PropertyInfo.create return ObjectProperty* > > qdev: Make qdev_class_add_property() more flexible I'm queueing patches 15-25 (above) on machine-next. > > qdev: Separate generic and device-specific property registration > > qdev: Rename qdev_propinfo_* to field_prop_* > > qdev: Move qdev_prop_tpm declaration to tpm_prop.h > > qdev: Rename qdev_prop_* to prop_info_* > > qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr() > > qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen() > > tests: Add unit test for qdev array properties > > -- Eduardo