Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F2A5C4743D for ; Tue, 15 Dec 2020 23:59:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65BD322D57 for ; Tue, 15 Dec 2020 23:59:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726282AbgLOX7L (ORCPT ); Tue, 15 Dec 2020 18:59:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:60888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727892AbgLOXWb (ORCPT ); Tue, 15 Dec 2020 18:22:31 -0500 Date: Tue, 15 Dec 2020 15:20:21 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1608074422; bh=H/WsDv6Hr0m1p3mQyWI/vcJTE2nDaHvCBjRkgt+V0cY=; h=From:To:Subject:From; b=JGsyFnSdeqM+ZzxFQdMFIXN9+Ns8QYszxxqlE6pyjH/obxylxEHd/VMtW5OeSvJtt 4T41CqE4A+7yRpyQu94e8koTLZcXjCkwY5Xh/w7Gmczloh51I71muclUg+h9/O9UCo hGQO27c4F0Z3RjvqSEa0MEYXpf+WJDwaVCnslWO0= From: akpm@linux-foundation.org To: andreyknvl@google.com, aryabinin@virtuozzo.com, corbet@lwn.net, dvyukov@google.com, elver@google.com, glider@google.com, jiangshanlai@gmail.com, matthias.bgg@gmail.com, mm-commits@vger.kernel.org, tj@kernel.org, walter-zh.wu@mediatek.com Subject: [merged] workqueue-kasan-record-workqueue-stack.patch removed from -mm tree Message-ID: <20201215232021.dKD1c_6ci%akpm@linux-foundation.org> User-Agent: s-nail v14.8.16 Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: workqueue: kasan: record workqueue stack has been removed from the -mm tree. Its filename was workqueue-kasan-record-workqueue-stack.patch This patch was dropped because it was merged into mainline or a subsystem tree ------------------------------------------------------ From: Walter Wu Subject: workqueue: kasan: record workqueue stack Patch series "kasan: add workqueue stack for generic KASAN", v5. Syzbot reports many UAF issues for workqueue, see [1]. In some of these access/allocation happened in process_one_work(), we see the free stack is useless in KASAN report, it doesn't help programmers to solve UAF for workqueue issue. This patchset improves KASAN reports by making them to have workqueue queueing stack. It is useful for programmers to solve use-after-free or double-free memory issue. Generic KASAN also records the last two workqueue stacks and prints them in KASAN report. It is only suitable for generic KASAN. [1]https://groups.google.com/g/syzkaller-bugs/search?q=%22use-after-free%22+process_one_work [2]https://bugzilla.kernel.org/show_bug.cgi?id=198437 This patch (of 4): When analyzing use-after-free or double-free issue, recording the enqueuing work stacks is helpful to preserve usage history which potentially gives a hint about the affected code. For workqueue it has turned out to be useful to record the enqueuing work call stacks. Because user can see KASAN report to determine whether it is root cause. They don't need to enable debugobjects, but they have a chance to find out the root cause. Link: https://lkml.kernel.org/r/20201203022148.29754-1-walter-zh.wu@mediatek.com Link: https://lkml.kernel.org/r/20201203022442.30006-1-walter-zh.wu@mediatek.com Signed-off-by: Walter Wu Suggested-by: Marco Elver Acked-by: Marco Elver Acked-by: Tejun Heo Reviewed-by: Dmitry Vyukov Reviewed-by: Andrey Konovalov Cc: Andrey Ryabinin Cc: Alexander Potapenko Cc: Lai Jiangshan Cc: Marco Elver Cc: Matthias Brugger Cc: Jonathan Corbet Signed-off-by: Andrew Morton --- kernel/workqueue.c | 3 +++ 1 file changed, 3 insertions(+) --- a/kernel/workqueue.c~workqueue-kasan-record-workqueue-stack +++ a/kernel/workqueue.c @@ -1327,6 +1327,9 @@ static void insert_work(struct pool_work { struct worker_pool *pool = pwq->pool; + /* record the work call stack in order to print it in KASAN reports */ + kasan_record_aux_stack(work); + /* we own @work, set data and link */ set_work_pwq(work, pwq, extra_flags); list_add_tail(&work->entry, head); _ Patches currently in -mm which might be from walter-zh.wu@mediatek.com are