From: Pablo Neira Ayuso Date: Wed, 16 Dec 2020 10:02:30 +0000 Subject: Re: [PATCH][next] netfilter: nftables: fix incorrect increment of loop counter Message-Id: <20201216100230.GA10280@salvia> List-Id: References: <20201214234015.85072-1-colin.king@canonical.com> In-Reply-To: <20201214234015.85072-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Jozsef Kadlecsik , Florian Westphal , "David S . Miller" , Jakub Kicinski , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, Dec 14, 2020 at 11:40:15PM +0000, Colin King wrote: > From: Colin Ian King > > The intention of the err_expr cleanup path is to iterate over the > allocated expr_array objects and free them, starting from i - 1 and > working down to the start of the array. Currently the loop counter > is being incremented instead of decremented and also the index i is > being used instead of k, repeatedly destroying the same expr_array > element. Fix this by decrementing k and using k as the index into > expr_array. Applied to nf.git, thanks.