Date: Thu, 17 Dec 2020 09:13:18 +0100 From: Domagoj Pensa Message-ID: <20201217081318.GA3562@...2540...> References: <20201215171600.25534-1-domagoj@...2540...> <202012151921.0BFJLpZH034686@...2054...> MIME-Version: 1.0 In-Reply-To: <202012151921.0BFJLpZH034686@...2054...> Subject: Re: [Openvpn-devel] [PATCH applied] Re: Fix too early argv freeing when registering DNS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Content-Disposition: inline To: Gert Doering Cc: openvpn-devel@lists.sourceforge.net Hi! You're welcome. I'm glad that it helps. Even if it is just one line of code removed. :) Best regards, Domagoj On Tue, Dec 15, 2020 at 08:21:51PM +0100, Gert Doering wrote: > Thanks. As already said, all of a sudden it is very obvious > why it is crashing here... somewhat annoying that this wasn't > noticed before 2.5.0 release, though. > > I've stared-at-code, and tested this on Win10 (ubuntu 18 / mingw build) > with a config with --register-dns. Without the patch, crash, with the > patch, it just works. > > Testing is not fully straightforward, as you can not "just run" such > a config, but you need to either run openvpn-gui as admin, or run > openvpn from a admin-cmd.exe - and it never OOMs for me, just never > proceeeds after "ipconfig.exe /flushdns". > > Thanks :-) > > Your patch has been applied to the master and release/2.5 branch. > > commit ab4688e3bd78d010ccc96adec66ab552bd009328 (master) > commit 2f2df474158b6c24325a47334fc8b5eb77a69b85 (release/2.5) > Author: Domagoj Pensa > Date: Tue Dec 15 18:16:00 2020 +0100 > > Fix too early argv freeing when registering DNS > > Signed-off-by: Domagoj Pensa > Acked-by: Gert Doering > Message-Id: <20201215171600.25534-1-domagoj@...2540...> > URL: https://www.mail-archive.com/search?l=mid&q=20201215171600.25534-1-domagoj@...2540... > Signed-off-by: Gert Doering > > > -- > kind regards, > > Gert Doering >