From: Sam Ravnborg Date: Fri, 18 Dec 2020 21:16:38 +0000 Subject: Re: [PATCH v1 02/13] sparc32: Drop floppy support Message-Id: <20201218211638.GA2421393@ravnborg.org> List-Id: References: <20201218184347.2180772-1-sam@ravnborg.org> <20201218184347.2180772-3-sam@ravnborg.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Bergmann Cc: David S Miller , sparclinux , Andreas Larsson , Alexey Dobriyan , Al Viro , Andrew Morton , Anshuman Khandual , Arvind Sankar , Christian Brauner , Denis Efremov , Dmitry Safonov <0x7f454c46@gmail.com>, Geert Uytterhoeven , Greg Kroah-Hartman , Ira Weiny , Lorenzo Pieralisi , Mark Rutland , Mike Rapoport , Pekka Enberg , Peter Zijlstra , Stephen Rothwell , Thomas Gleixner , Will Deacon , Willy Tarreau , "linux-kernel@vger.kernel.org" , debian-sparc@lists.debian.org On Fri, Dec 18, 2020 at 09:57:47PM +0100, Arnd Bergmann wrote: > On Fri, Dec 18, 2020 at 7:43 PM Sam Ravnborg wrote: > > > > LEON do not have floppy support so we can drop it > > > > Signed-off-by: Sam Ravnborg > > Cc: "David S. Miller" > > Cc: Sam Ravnborg > > Cc: Mike Rapoport > > Cc: Andrew Morton > > Cc: Denis Efremov > > Cc: Willy Tarreau > > Cc: Christian Brauner > > Cc: sparclinux@vger.kernel.org > > Cc: Arnd Bergmann > > Cc: Andreas Larsson > > --- > > arch/sparc/Kconfig | 2 +- > > arch/sparc/include/asm/floppy.h | 786 ++++++++++++++++++++++++++++- > > arch/sparc/include/asm/floppy_32.h | 393 --------------- > > arch/sparc/include/asm/floppy_64.h | 779 ---------------------------- > > Rather than renaming the floppy_64.h to floppy.h, it might be easier to just > remove the #else from floppy.h, similar to what asm/adi.h does. That is what I had first but then thought it pointless with a wrapper file. I will revert back to use floppy_64.h for now - we can always consolidate header files later. Sam