Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F39C4361B for ; Fri, 18 Dec 2020 23:20:06 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73DF523BA7 for ; Fri, 18 Dec 2020 23:20:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73DF523BA7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608333604; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Zxn8/HmCqrlaOABdtIB/ZWtd/9j1HH8jDedZKlgtPPw=; b=W+uZkUeiEKymguX26ugjgOvxGP3Z8hmnMRpF5mO775GxG+jvsgwdbo2krjxXlRDIT1mLlw wGL89KR4D5kijtPA7FvdbLYWXUVr+NANJHdzwGvAuuw+ZGpUz7xvznJeIRT1SqijYqePg7 OTcAazoIS384bT6d/lYVfqnSiH4Pi/c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-520-FY3Rn6piMqG7UukQb4uObw-1; Fri, 18 Dec 2020 18:20:02 -0500 X-MC-Unique: FY3Rn6piMqG7UukQb4uObw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AF98D801817; Fri, 18 Dec 2020 23:19:57 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 926D01002382; Fri, 18 Dec 2020 23:19:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6BABB1809C9F; Fri, 18 Dec 2020 23:19:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0BINJtRr029512 for ; Fri, 18 Dec 2020 18:19:55 -0500 Received: by smtp.corp.redhat.com (Postfix) id D5637299A1; Fri, 18 Dec 2020 23:19:55 +0000 (UTC) Received: from octiron.msp.redhat.com (octiron.msp.redhat.com [10.15.80.209]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76AD52999F; Fri, 18 Dec 2020 23:19:52 +0000 (UTC) Received: from octiron.msp.redhat.com (localhost.localdomain [127.0.0.1]) by octiron.msp.redhat.com (8.14.9/8.14.9) with ESMTP id 0BINJpQ4010029; Fri, 18 Dec 2020 17:19:51 -0600 Received: (from bmarzins@localhost) by octiron.msp.redhat.com (8.14.9/8.14.9/Submit) id 0BINJoJG010028; Fri, 18 Dec 2020 17:19:50 -0600 Date: Fri, 18 Dec 2020 17:19:50 -0600 From: Benjamin Marzinski To: mwilck@suse.com Message-ID: <20201218231950.GP3103@octiron.msp.redhat.com> References: <20201218222714.16209-1-mwilck@suse.com> MIME-Version: 1.0 In-Reply-To: <20201218222714.16209-1-mwilck@suse.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: dm-devel@redhat.com Cc: dm-devel@redhat.com Subject: Re: [dm-devel] [PATCH 1/2] multipath-tools tests: unversioned .so for valgrind tests X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Dec 18, 2020 at 11:27:13PM +0100, mwilck@suse.com wrote: > From: Martin Wilck > > We need to the same thing for valgrind tests as we did in > 448752f ("libmultipath: create separate .so for unit tests"). > Reviewed-by: Benjamin Marzinski > Signed-off-by: Martin Wilck > --- > tests/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile b/tests/Makefile > index 54da774..50673fa 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -76,7 +76,7 @@ lib/libchecktur.so: > > %.vgr: %-test lib/libchecktur.so > @echo == running valgrind for $< == > - @LD_LIBRARY_PATH=$(multipathdir):$(mpathcmddir) \ > + @LD_LIBRARY_PATH=.:$(mpathcmddir) \ > valgrind --leak-check=full --error-exitcode=128 ./$< >$@ 2>&1 > > OBJS = $(TESTS:%=%.o) $(HELPERS) > -- > 2.29.0 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel