Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD68BC433E0 for ; Mon, 21 Dec 2020 17:08:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4673F22BF3 for ; Mon, 21 Dec 2020 17:08:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4673F22BF3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2+lsuB7j/xKyrRtl4tz3gA3GaCfAvWxeV+e3zdgJaLw=; b=FsRDBaVYMe5Cjll5YdcG06fPV lYZfkfqo67dlCDbu+QN4JPlF36YQwOvqHByssosVF2cfoOgjgT5QsLufhHu608b++HMBGd4K9ItmC vdbTIR8UENkRom10e0w9Z0FqSMT+6ttbscX+QxuIvYh6Fg+j79y37ADecb1EqsYr7AMoypET5U55M qtLlLLzyuh4CBCryWOTaIYYrwQuUvtVRYx/nBVwhQtajBaAEI9+lb1+Y0F0wOJFp6QEFHvqtOKMp7 C0axUv+uGIzEeMdHk27aBvG/43T7oveGeh9H6vhQrpYfT8OPw96c77vrSraCAuCcVHO8Itm+yg8P4 nN0OiIofg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krOen-0006BJ-6o; Mon, 21 Dec 2020 17:07:37 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krOek-00069o-B9 for linux-arm-kernel@lists.infradead.org; Mon, 21 Dec 2020 17:07:35 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1krOee-00DAiX-LM; Mon, 21 Dec 2020 18:07:28 +0100 Date: Mon, 21 Dec 2020 18:07:28 +0100 From: Andrew Lunn To: kostap@marvell.com Subject: Re: [PATCH v3 3/4] arm64: dts: cn913x: add device trees for topology B boards Message-ID: <20201221170728.GJ3026679@lunn.ch> References: <20201221163827.6679-1-kostap@marvell.com> <20201221163827.6679-4-kostap@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201221163827.6679-4-kostap@marvell.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201221_120734_416140_C142306D X-CRM114-Status: UNSURE ( 9.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tmn505@gmail.com, jaz@semihalf.com, gregory.clement@bootlin.com, nadavh@marvell.com, robh+dt@kernel.org, stefanc@marvell.com, mw@semihalf.com, bpeled@marvell.com, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > - cp0_sfp_eth0: sfp-eth@0 { > - compatible = "sff,sfp"; > - i2c-bus = <&cp0_sfpp0_i2c>; > - los-gpio = <&cp0_module_expander1 11 GPIO_ACTIVE_HIGH>; > - mod-def0-gpio = <&cp0_module_expander1 10 GPIO_ACTIVE_LOW>; > - tx-disable-gpio = <&cp0_module_expander1 9 GPIO_ACTIVE_HIGH>; > - tx-fault-gpio = <&cp0_module_expander1 8 GPIO_ACTIVE_HIGH>; > - /* > - * SFP cages are unconnected on early PCBs because of an the I2C > - * lanes not being connected. Prevent the port for being > - * unusable by disabling the SFP node. > - */ > - status = "disabled"; Does the B also have the broken SFP cage? Is there a newer revision which fixes the PCB? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel