From: Domagoj Pensa Message-ID: <20201224115910.10129-1-domagoj@...2540...> Date: Thu, 24 Dec 2020 12:59:10 +0100 MIME-Version: 1.0 Subject: [Openvpn-devel] [PATCH v2] Remove 1 second delay before running netsh List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf8" Content-Transfer-Encoding: quoted-printable To: openvpn-devel@lists.sourceforge.net When running various netsh commands before each 1 second sleep is added. As more netsh commands are run, especially for Wintun adapters, that can add to a noticable delayed connecting time. This should be safe. No problems were found in tests and all netsh commands executed properly with delay removed. Also, no delays are used in a similar code in interactive service and netsh command executions are guarded with a semaphore. Instead of removing management_sleep(1), management_sleep(0) is used as a replacement to allow processing any pending actions on the management interface without any wait. Signed-off-by: Domagoj Pensa --- src/openvpn/tun.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index 400a50ca..0751ae46 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -5207,7 +5207,7 @@ netsh_command(const struct argv *a, int n, int msglev= el) for (i =3D 0; i < n; ++i) { bool status; - management_sleep(1); + management_sleep(0); netcmd_semaphore_lock(); argv_msg_prefix(M_INFO, a, "NETSH"); status =3D openvpn_execve_check(a, NULL, 0, "ERROR: netsh command = failed"); --=20 2.29.2