Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C94EC433E0 for ; Mon, 4 Jan 2021 10:21:13 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35EA821D93 for ; Mon, 4 Jan 2021 10:21:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35EA821D93 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=antioche.eu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.61056.107137 (Exim 4.92) (envelope-from ) id 1kwMyo-0008UL-Rk; Mon, 04 Jan 2021 10:20:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 61056.107137; Mon, 04 Jan 2021 10:20:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwMyo-0008UE-OL; Mon, 04 Jan 2021 10:20:50 +0000 Received: by outflank-mailman (input) for mailman id 61056; Mon, 04 Jan 2021 10:20:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwMyn-0008U9-0u for xen-devel@lists.xenproject.org; Mon, 04 Jan 2021 10:20:49 +0000 Received: from chassiron.antioche.eu.org (unknown [2001:41d0:fe9d:1101::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id eb6cfb95-c568-4a75-93f7-d97646e88084; Mon, 04 Jan 2021 10:20:45 +0000 (UTC) Received: from rochebonne.antioche.eu.org (rochebonne [10.0.0.1]) by chassiron.antioche.eu.org (8.15.2/8.15.2) with ESMTP id 104AKbIC005829; Mon, 4 Jan 2021 11:20:37 +0100 (MET) Received: by rochebonne.antioche.eu.org (Postfix, from userid 1210) id 5EBA5281D; Mon, 4 Jan 2021 11:20:37 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb6cfb95-c568-4a75-93f7-d97646e88084 Date: Mon, 4 Jan 2021 11:20:37 +0100 From: Manuel Bouyer To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: xen-devel@lists.xenproject.org, Ian Jackson Subject: Re: [PATCH 05/24] Introduce locking functions for block device setup on NetBSD Message-ID: <20210104102037.GA2005@antioche.eu.org> References: <20201214163623.2127-1-bouyer@netbsd.org> <20201214163623.2127-6-bouyer@netbsd.org> <20201229112909.kprjtysxkg4p6y2i@Air-de-Roger> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201229112909.kprjtysxkg4p6y2i@Air-de-Roger> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (chassiron.antioche.eu.org [151.127.5.145]); Mon, 04 Jan 2021 11:20:37 +0100 (MET) On Tue, Dec 29, 2020 at 12:29:09PM +0100, Roger Pau Monné wrote: > I think you want tot CC the tools dev on this one, specially Ian who > knows how the Linux one is implemented and can likely give valuable > input. > > On Mon, Dec 14, 2020 at 05:36:04PM +0100, Manuel Bouyer wrote: > > --- > > tools/hotplug/NetBSD/Makefile | 1 + > > tools/hotplug/NetBSD/block | 5 ++- > > tools/hotplug/NetBSD/locking.sh | 72 +++++++++++++++++++++++++++++++++ > > Seeing the file itself, I don't think there's any NetBSD specific > stuff, so we might want to consider putting it in BSD/ instead, so it > can be used by FreeBSD also? I'm not sure if FreeBSD needs the locking stuff. Also, there are certainly differences in block device handling between FreeBSD and NetBSD. Both OSes have diverged in this area. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --