Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90791C433E0 for ; Mon, 4 Jan 2021 10:32:16 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CD5520715 for ; Mon, 4 Jan 2021 10:32:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CD5520715 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=antioche.eu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.61081.107198 (Exim 4.92) (envelope-from ) id 1kwN9f-0001UH-3K; Mon, 04 Jan 2021 10:32:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 61081.107198; Mon, 04 Jan 2021 10:32:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwN9f-0001UA-0G; Mon, 04 Jan 2021 10:32:03 +0000 Received: by outflank-mailman (input) for mailman id 61081; Mon, 04 Jan 2021 10:32:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwN9e-0001U5-2h for xen-devel@lists.xenproject.org; Mon, 04 Jan 2021 10:32:02 +0000 Received: from chassiron.antioche.eu.org (unknown [2001:41d0:fe9d:1101::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 37e98344-9bd2-4179-a578-b830f5371ab6; Mon, 04 Jan 2021 10:32:00 +0000 (UTC) Received: from rochebonne.antioche.eu.org (rochebonne [10.0.0.1]) by chassiron.antioche.eu.org (8.15.2/8.15.2) with ESMTP id 104AVuMd028235; Mon, 4 Jan 2021 11:31:56 +0100 (MET) Received: by rochebonne.antioche.eu.org (Postfix, from userid 1210) id 8DD08281D; Mon, 4 Jan 2021 11:31:56 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37e98344-9bd2-4179-a578-b830f5371ab6 Date: Mon, 4 Jan 2021 11:31:56 +0100 From: Manuel Bouyer To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: xen-devel@lists.xenproject.org Subject: Re: [PATCH 13/24] Don't assume tv_sec is a unsigned long (for NetBSD) Message-ID: <20210104103156.GF2005@antioche.eu.org> References: <20201214163623.2127-1-bouyer@netbsd.org> <20201214163623.2127-14-bouyer@netbsd.org> <20201229140215.zl5yju6hm7wcacht@Air-de-Roger> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201229140215.zl5yju6hm7wcacht@Air-de-Roger> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (chassiron.antioche.eu.org [151.127.5.145]); Mon, 04 Jan 2021 11:31:56 +0100 (MET) On Tue, Dec 29, 2020 at 03:02:15PM +0100, Roger Pau Monné wrote: > On Mon, Dec 14, 2020 at 05:36:12PM +0100, Manuel Bouyer wrote: > > --- > > tools/libs/light/libxl_create.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c > > index 321a13e519..44691010bc 100644 > > --- a/tools/libs/light/libxl_create.c > > +++ b/tools/libs/light/libxl_create.c > > @@ -496,7 +496,7 @@ int libxl__domain_build(libxl__gc *gc, > > vments[2] = "image/ostype"; > > vments[3] = "hvm"; > > vments[4] = "start_time"; > > - vments[5] = GCSPRINTF("%lu.%02d", start_time.tv_sec,(int)start_time.tv_usec/10000); > > + vments[5] = GCSPRINTF("%jd.%02d", start_time.tv_sec,(int)start_time.tv_usec/10000); > > You don't cast tv_sec to intmax_t here... > > > > > localents = libxl__calloc(gc, 13, sizeof(char *)); > > i = 0; > > @@ -535,7 +535,7 @@ int libxl__domain_build(libxl__gc *gc, > > vments[i++] = "image/kernel"; > > vments[i++] = (char *) state->pv_kernel.path; > > vments[i++] = "start_time"; > > - vments[i++] = GCSPRINTF("%lu.%02d", start_time.tv_sec,(int)start_time.tv_usec/10000); > > + vments[i++] = GCSPRINTF("%jd.%02d", (intmax_t)start_time.tv_sec,(int)start_time.tv_usec/10000); > > ... yet you do it here. I think the first occurrence is missing the > cast? thanks, fixed. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --