Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CAB7C433DB for ; Tue, 5 Jan 2021 17:40:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14BF322D01 for ; Tue, 5 Jan 2021 17:40:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14BF322D01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A05858985A; Tue, 5 Jan 2021 17:40:15 +0000 (UTC) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0131D8985A for ; Tue, 5 Jan 2021 17:40:14 +0000 (UTC) Received: by mail-io1-f41.google.com with SMTP id o6so89492iob.10 for ; Tue, 05 Jan 2021 09:40:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8QCUqXr2bzGc5ddkxZAj8Vxc5oTvsGwo9juSuaK/DNc=; b=IINQvzA7jFPM0NBLzoy9gREzgOt68IOd+tod7Y7sxbWfutYwHOXeUv4gid4SdsTZV7 /H9gJmnHT2uJaYc19XKQvOjC3zqKsS7F5YXTnlrqVRq8NrD041tHhZL/8XD5Z1pxFaE9 ms6J+c4u3HImobdYBJjgv3u8j5X/XXB4wuJOMeBi29iWsIsCicR/zwCFvkBwRQBlTBsy 1dLLvsTZfOFrzhnCOMRHpQoG0js+NhcGfrlBcMvFiYODwtUd9ZPgAW5WbisjhXOOH5Mk KcMZ/aob/ZJDp0vXrtvBoDpcpoor4yBGlTIr6D8s8XnBf8wXmgcqK4Cuc+H/jfkyUj6C Pcxw== X-Gm-Message-State: AOAM530be5/Ty3fO0zw8glgcJm/XfttjY/agoJlR3Qp1Yp2wiR6tPht4 5FdgV3gjuG5d7Nq4R5McaA== X-Google-Smtp-Source: ABdhPJxCW42aLPbGC5oVtd7TRg3rkrFk+Qrm1SC6TjLARKSfiB9JNiyQ7YL2gLDjCHBjUScpozxZgA== X-Received: by 2002:a02:7692:: with SMTP id z140mr666018jab.21.1609868414264; Tue, 05 Jan 2021 09:40:14 -0800 (PST) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id y15sm121208ili.65.2021.01.05.09.40.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jan 2021 09:40:13 -0800 (PST) Received: (nullmailer pid 426116 invoked by uid 1000); Tue, 05 Jan 2021 17:40:08 -0000 Date: Tue, 5 Jan 2021 10:40:08 -0700 From: Rob Herring To: Greg Kroah-Hartman Subject: Re: [PATCH] dt-bindings: Add missing array size constraints Message-ID: <20210105174008.GB1875909@robh.at.kernel.org> References: <20210104230253.2805217-1-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-usb@vger.kernel.org, linux-iio@vger.kernel.org, linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , linux-ide@vger.kernel.org, Thierry Reding , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, Chanwoo Choi , Marc Zyngier , Bartosz Golaszewski , Chen-Yu Tsai , MyungJoo Ham , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Jakub Kicinski , linux-media@vger.kernel.org, Ohad Ben-Cohen , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org, Thomas Gleixner , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Jens Axboe , Stephen Boyd , netdev@vger.kernel.org, Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Sebastian Reichel , "David S. Miller" , Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 05, 2021 at 02:04:14PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: > > DT properties which can have multiple entries need to specify what the > > entries are and define how many entries there can be. In the case of > > only a single entry, just 'maxItems: 1' is sufficient. > > > > Add the missing entry constraints. These were found with a modified > > meta-schema. Unfortunately, there are a few cases where the size > > constraints are not defined such as common bindings, so the meta-schema > > can't be part of the normal checks. > > > > Cc: Jens Axboe > > Cc: Stephen Boyd > > Cc: Thierry Reding > > Cc: MyungJoo Ham > > Cc: Chanwoo Choi > > Cc: Linus Walleij > > Cc: Bartosz Golaszewski > > Cc: Jonathan Cameron > > Cc: Dmitry Torokhov > > Cc: Thomas Gleixner > > Cc: Marc Zyngier > > Cc: Mauro Carvalho Chehab > > Cc: Chen-Yu Tsai > > Cc: Ulf Hansson > > Cc: "David S. Miller" > > Cc: Jakub Kicinski > > Cc: Sebastian Reichel > > Cc: Ohad Ben-Cohen > > Cc: Bjorn Andersson > > Cc: Greg Kroah-Hartman > > Signed-off-by: Rob Herring > > > > > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > index 247ef00381ea..f76b25f7fc7a 100644 > > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > @@ -83,6 +83,7 @@ properties: > > Phandle of a companion. > > > > phys: > > + maxItems: 1 > > description: PHY specifier for the USB PHY > > > > phy-names: > > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > index 2178bcc401bc..8e2bd61f2075 100644 > > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > @@ -71,6 +71,7 @@ properties: > > Overrides the detected port count > > > > phys: > > + maxItems: 1 > > description: PHY specifier for the USB PHY > > > > phy-names: > > diff --git a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > index 678396eeeb78..f506225a4d57 100644 > > --- a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > +++ b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > @@ -40,7 +40,7 @@ properties: > > - const: mc > > > > phys: > > - description: PHY specifier for the USB PHY > > + maxItems: 1 > > > > usb-role-switch: > > type: boolean > > Any reason you dropped the description for this entry, but not the other > ones above? No, I should have dropped those too. I dropped cases of genericish descriptions on common properties. There's nothing specific to this binding here really. > > > diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > index 388245b91a55..adce36e48bc9 100644 > > --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > @@ -15,13 +15,14 @@ properties: > > - const: ti,j721e-usb > > > > reg: > > - description: module registers > > + maxItems: 1 > > > > power-domains: > > description: > > PM domain provider node and an args specifier containing > > the USB device id value. See, > > Documentation/devicetree/bindings/soc/ti/sci-pm-domain.txt > > + maxItems: 1 > > > > clocks: > > description: Clock phandles to usb2_refclk and lpm_clk > > Same here, why remove the description? Really, the question is why keep 'description' on power-domains. Perhaps there's a little value in the reference to sci-pm-domain.txt, so I left it. Rob _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel