Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C72EFC433DB for ; Wed, 6 Jan 2021 19:09:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 598372311B for ; Wed, 6 Jan 2021 19:09:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 598372311B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxEBa-0005Mt-7k for qemu-devel@archiver.kernel.org; Wed, 06 Jan 2021 14:09:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxEAb-0004vJ-IJ for qemu-devel@nongnu.org; Wed, 06 Jan 2021 14:08:33 -0500 Received: from mga05.intel.com ([192.55.52.43]:57567) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxEAY-0003iu-Tj for qemu-devel@nongnu.org; Wed, 06 Jan 2021 14:08:32 -0500 IronPort-SDR: 4x2Nbu8wzS76hRucoXiOyB9dmvd1WnvgU8jxbgeMA0cAgaLLaK9ARrtHbhFJyCClKwMwU/tDKJ Via0hGUP2MLg== X-IronPort-AV: E=McAfee;i="6000,8403,9856"; a="262091349" X-IronPort-AV: E=Sophos;i="5.79,327,1602572400"; d="scan'208";a="262091349" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2021 11:08:28 -0800 IronPort-SDR: JTALSDYb2XQUBs/DFjPMgp5DrxZDQJufWf2TnwHFagSQdLnfbw0BDphBUNOjg3wd5R9pSZ9sBJ JZJyBE4HxkHw== X-IronPort-AV: E=Sophos;i="5.79,327,1602572400"; d="scan'208";a="398340779" Received: from pthatich-mobl1.amr.corp.intel.com (HELO intel.com) ([10.252.142.206]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2021 11:08:27 -0800 Date: Wed, 6 Jan 2021 11:08:25 -0800 From: Ben Widawsky To: Jonathan Cameron Subject: Re: [Linuxarm] Re: [RFC PATCH v2 07/32] hw/cxl/device: Implement basic mailbox (8.2.8.4) Message-ID: <20210106190825.ed5w5p5tdk6v6f2u@intel.com> References: <20210105165323.783725-1-ben.widawsky@intel.com> <20210105165323.783725-8-ben.widawsky@intel.com> <20210106132123.00003a9d@Huawei.com> <20210106174014.00007407@Huawei.com> <20210106180556.2nw2p2alxxzdx55w@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210106180556.2nw2p2alxxzdx55w@intel.com> Received-SPF: pass client-ip=192.55.52.43; envelope-from=ben.widawsky@intel.com; helo=mga05.intel.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Dan@domain.invalid, Vishal Verma , qemu-devel@nongnu.org, Prashant V Agarwal =?utf-8?Q?=3Cagpr123=40gmail=2Ecom=3E=2C_Chris_Brow?= =?utf-8?Q?y_=3Ccbrowy=40avery-design=2Ecom=3E=2C__Michael_S=2E_Tsirkin__?= =?utf-8?Q?=3Cmst=40redhat=2Ecom=3E=2C_Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 21-01-06 10:05:57, Ben Widawsky wrote: > On 21-01-06 17:40:14, Jonathan Cameron wrote: > > On Wed, 6 Jan 2021 13:21:23 +0000 > > Jonathan Cameron wrote: > > > > > On Tue, 5 Jan 2021 08:52:58 -0800 > > > Ben Widawsky wrote: > > > [snip] > > I'm sorry you had to debug this. I had fixed this previously and it got lost. > I'm currently between test applications, so my regression testing isn't great. > > I think the fix should be something like this, but I can't easily test at the > moment: > > diff --git a/hw/cxl/cxl-device-utils.c b/hw/cxl/cxl-device-utils.c > index c515d45d20..b38e9b4c17 100644 > --- a/hw/cxl/cxl-device-utils.c > +++ b/hw/cxl/cxl-device-utils.c > @@ -102,6 +102,9 @@ static void mailbox_reg_write(void *opaque, hwaddr offset, uint64_t value, > { > CXLDeviceState *cxl_dstate = opaque; > > + if (offset >= A_CXL_DEV_CMD_PAYLOAD) > + stn_le_p(cxl_dstate->mbox_reg_state, size, value); > + > /* > * Lock is needed to prevent concurrent writes as well as to prevent writes > * coming in while the firmware is processing. Without background commands > > > + if (offset >= A_CXL_DEV_CMD_PAYLOAD) { + stn_le_p(cxl_dstate->mbox_reg_state, size, value); + return; + } + [snip] >