Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B409FC433E0 for ; Wed, 6 Jan 2021 20:46:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BD3D2311B for ; Wed, 6 Jan 2021 20:46:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BD3D2311B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cLkjIdf4KWky+ZDZ7UcU5+2hvzL2plINAPAr9rVfG1U=; b=d87ZMD1GlJYSVQ2kqH56+Mfqa kCX8rRsb1vju0PhTeQ4js91mwvl/dmsVl2HOMIlEWQZLJBLi2qRNskQ6S4WuQcGYPZLYQ/pg6mVFV iYEq/25n8an6SCwCn90FiGRGSKGwF8kF4oqrsmvxOQma6pk2sQA05FiO5JNlCuQ5HDATs0XLcB0gz FHuE8bu8Ux9+LO3Wkg9pYLv4dz9IgV1oFs45w0R4GDmuMi5/d2u+p0/Go8cL+kEBhCQUleOCIF1Jd cRVW7Xnf5XOippglglmIvVYPkJmXSbz+7kLa3TpBm+2xny2qbZHL5vVVf+XqQlGD4KVOZ9sOYSvQA Yvsdg+0rQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxFfF-0006YZ-3V; Wed, 06 Jan 2021 20:44:17 +0000 Received: from mail-out.m-online.net ([212.18.0.9]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxFf6-0006VI-JC for linux-arm-kernel@lists.infradead.org; Wed, 06 Jan 2021 20:44:09 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DB1Yf0HlNz1qs0Z; Wed, 6 Jan 2021 21:44:06 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DB1Yf033Tz1sFWf; Wed, 6 Jan 2021 21:44:06 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id wB5LB0z7pRoK; Wed, 6 Jan 2021 21:44:04 +0100 (CET) X-Auth-Info: SX+YpYpFai9fqf0Jl2Q3r21T+zy/SZ45RThMnmv+264= Received: from tr.lan (ip-89-176-112-137.net.upcbroadband.cz [89.176.112.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 6 Jan 2021 21:44:04 +0100 (CET) From: Marek Vasut To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/4] [RFC] ARM: dts: stm32: Add mux for ETHRX clock Date: Wed, 6 Jan 2021 21:43:46 +0100 Message-Id: <20210106204347.475920-3-marex@denx.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210106204347.475920-1-marex@denx.de> References: <20210106204347.475920-1-marex@denx.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_154408_841452_48F17EB0 X-CRM114-Status: GOOD ( 17.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Alexandre Torgue , Patrice Chotard , Patrick Delaunay , Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The implementation of ETH_RX_CLK/ETH_REF_CLK handling currently does not permit selecting the clock input from SoC pad. To make things worse, the implementation of this is partly present and is split between the clock driver and dwmac4 driver. Moreover, the ETHRX clock parent is incorrect. First, the ETHRX clock in clk-stm32mp1.c only represents the ETHRXEN gate, however it should represent also ETH_REF_CLK_SEL mux. The problem is that the ETH_REF_CLK_SEL mux is currently configured in the DWMAC4 driver and the ETH_REF_CLK_SEL bit is part of SYSCFG block, not the DWMAC4 or the clock block. Second, the ETHRX parent clock is either eth_clk_fb (ETHCK_K) or external ETH_RX_CLK/ETH_REF_CLK_SEL, it is never CK_AXI. This patch attempts to address the clock selection by adding fixed factor clock to DT, which allows the user to select its upstream clock. Signed-off-by: Marek Vasut Cc: Alexandre Torgue Cc: Maxime Coquelin Cc: Patrice Chotard Cc: Patrick Delaunay Cc: linux-stm32@st-md-mailman.stormreply.com To: linux-arm-kernel@lists.infradead.org --- arch/arm/boot/dts/stm32mp151.dtsi | 8 ++++++++ drivers/clk/clk-stm32mp1.c | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi index 32875eabd357..8c2a5d0875d8 100644 --- a/arch/arm/boot/dts/stm32mp151.dtsi +++ b/arch/arm/boot/dts/stm32mp151.dtsi @@ -82,6 +82,14 @@ clk_csi: clk-csi { compatible = "fixed-clock"; clock-frequency = <4000000>; }; + + clk_eth_rx: eth-rx-clk { + compatible = "fixed-factor-clock"; + clocks = <&rcc ETHCK_K>; + #clock-cells = <0>; + clock-div = <1>; + clock-mult = <1>; + }; }; thermal-zones { diff --git a/drivers/clk/clk-stm32mp1.c b/drivers/clk/clk-stm32mp1.c index a875649df8b8..63971d40f15c 100644 --- a/drivers/clk/clk-stm32mp1.c +++ b/drivers/clk/clk-stm32mp1.c @@ -1892,7 +1892,7 @@ static const struct clock_config stm32mp1_clock_cfg[] = { PCLK(MDMA, "mdma", "ck_axi", 0, G_MDMA), PCLK(GPU, "gpu", "ck_axi", 0, G_GPU), PCLK(ETHTX, "ethtx", "ck_axi", 0, G_ETHTX), - PCLK(ETHRX, "ethrx", "ck_axi", 0, G_ETHRX), + PCLK(ETHRX, "ethrx", "eth-rx-clk", 0, G_ETHRX), PCLK(ETHMAC, "ethmac", "ck_axi", 0, G_ETHMAC), PCLK(FMC, "fmc", "ck_axi", CLK_IGNORE_UNUSED, G_FMC), PCLK(QSPI, "qspi", "ck_axi", CLK_IGNORE_UNUSED, G_QSPI), -- 2.29.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel