Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D98EC433E0 for ; Thu, 7 Jan 2021 12:56:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3688E2336D for ; Thu, 7 Jan 2021 12:56:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3688E2336D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AF4D86E456; Thu, 7 Jan 2021 12:56:52 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 360966E456 for ; Thu, 7 Jan 2021 12:56:51 +0000 (UTC) IronPort-SDR: TmDlI51kaRFWlOXuxP7Zuyjki64wYS08BBNfOOZRuPL4c0HmCVhRyxUMFbpzC2DZsNG+LJafYm CY6NWvn/7riw== X-IronPort-AV: E=McAfee;i="6000,8403,9856"; a="177517937" X-IronPort-AV: E=Sophos;i="5.79,329,1602572400"; d="scan'208";a="177517937" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2021 04:56:50 -0800 IronPort-SDR: viuZ+GPMkEDCZ8M5vVixYsoUo7Gmx2D6cP7ClgiMhyXCUyVp+Et/ZrjU2CpeWi9cpr1KzRu7Sb f0Omxv6bmEng== X-IronPort-AV: E=Sophos;i="5.79,329,1602572400"; d="scan'208";a="351248781" Received: from ideak-desk.fi.intel.com ([10.237.68.141]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2021 04:56:49 -0800 Date: Thu, 7 Jan 2021 14:56:45 +0200 From: Imre Deak To: Jani Nikula Message-ID: <20210107125645.GA219572@ideak-desk.fi.intel.com> References: <20201209153952.3397959-1-imre.deak@intel.com> <87a6tl1b8r.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87a6tl1b8r.fsf@intel.com> Subject: Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Jan 07, 2021 at 09:01:40AM +0200, Jani Nikula wrote: > On Wed, 09 Dec 2020, Imre Deak wrote: > > For an enabled DSC during HW readout the corresponding power reference > > is taken along the CRTC power domain references in > > get_crtc_power_domains(). Remove the incorrect get ref from the DSI > > encoder hook. > > Does this fix [1] which is v5.11-rc2 on TGL DSI? Yes, looks like it: <4> [199.269612] i915 0000:00:02.0: i915 raw-wakerefs=1 wakelocks=1 on cleanup ... <7> [199.277233] i915 Wakeref x1 taken at: intel_display_power_get+0x1f/0x60 [i915] intel_modeset_setup_hw_state+0xbcf/0x19b0 [i915] > Should we pick this up for fixes? Yes. Thanks, Imre > BR, > Jani. > > > [1] https://intel-gfx-ci.01.org/tree/drm-intel-fixes/CI_DIF_538/fi-tgl-dsi/igt@gem_exec_suspend@basic-s0.html > > > > > > > Cc: Vandita Kulkarni > > Cc: Jani Nikula > > Signed-off-by: Imre Deak > > --- > > drivers/gpu/drm/i915/display/icl_dsi.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c > > index a9439b415603..b3533a32f8ba 100644 > > --- a/drivers/gpu/drm/i915/display/icl_dsi.c > > +++ b/drivers/gpu/drm/i915/display/icl_dsi.c > > @@ -1616,10 +1616,6 @@ static void gen11_dsi_get_power_domains(struct intel_encoder *encoder, > > > > get_dsi_io_power_domains(i915, > > enc_to_intel_dsi(encoder)); > > - > > - if (crtc_state->dsc.compression_enable) > > - intel_display_power_get(i915, > > - intel_dsc_power_domain(crtc_state)); > > } > > > > static bool gen11_dsi_get_hw_state(struct intel_encoder *encoder, > > -- > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx