Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56E27C433DB for ; Fri, 8 Jan 2021 08:34:06 +0000 (UTC) Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id A73A923435 for ; Fri, 8 Jan 2021 08:34:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A73A923435 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83D42140E58; Fri, 8 Jan 2021 09:34:04 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 8FB2D140E55 for ; Fri, 8 Jan 2021 09:34:03 +0100 (CET) IronPort-SDR: 2Japr2bLst73FuvaFNfWGpqgy4y5JUT4NN+ef5dFOlsbWjYwQDdSZYAOlgMy6NrxLB0OCGZUC+ KJFJiQyARAlA== X-IronPort-AV: E=McAfee;i="6000,8403,9857"; a="241637298" X-IronPort-AV: E=Sophos;i="5.79,330,1602572400"; d="scan'208";a="241637298" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2021 00:34:02 -0800 IronPort-SDR: QcluyyflnHyQzdgeimYxThCAfbE77pBwK76K/j6Qrn/qRXW7EVMjKFSRH50c2rBah94H1D31N5 75mGMlmFuT2Q== X-IronPort-AV: E=Sophos;i="5.79,330,1602572400"; d="scan'208";a="380053583" Received: from unknown (HELO intel-npg-odc-srv02.cd.intel.com) ([10.240.178.186]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2021 00:33:58 -0800 From: Murphy Yang To: dev@dpdk.org Cc: qiming.yang@intel.com, ferruh.yigit@intel.com, jia.guo@intel.com, beilei.xing@intel.com, stevex.yang@intel.com, Murphy Yang Date: Fri, 8 Jan 2021 08:30:11 +0000 Message-Id: <20210108083011.28700-1-murphyx.yang@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] net/i40e: i40e PMD APIs add input pointer null check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Pointer 'NULL' check for 'mac_addr' or 'conf' within i40e PMD APIs. Fixes: 66c78f4799ff ("net/i40e: add support for packet template to flow director") Fixes: 04b443fb2c43 ("net/i40e: fix port id type") Signed-off-by: Murphy Yang --- drivers/net/i40e/rte_pmd_i40e.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c index 790d042002..2e34140c5b 100644 --- a/drivers/net/i40e/rte_pmd_i40e.c +++ b/drivers/net/i40e/rte_pmd_i40e.c @@ -2366,6 +2366,9 @@ rte_pmd_i40e_add_vf_mac_addr(uint16_t port, uint16_t vf_id, struct i40e_mac_filter_info mac_filter; int ret; + if (mac_addr == NULL) + return -EINVAL; + if (i40e_validate_mac_addr((u8 *)mac_addr) != I40E_SUCCESS) return -EINVAL; @@ -3042,6 +3045,9 @@ int rte_pmd_i40e_flow_add_del_packet_template( RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); + if (conf == NULL) + return -EINVAL; + if (!is_i40e_supported(dev)) return -ENOTSUP; -- 2.17.1