Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20FBCC433E0 for ; Tue, 12 Jan 2021 10:10:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B244522CBE for ; Tue, 12 Jan 2021 10:10:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B244522CBE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BDFC389E59; Tue, 12 Jan 2021 10:10:20 +0000 (UTC) Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by gabe.freedesktop.org (Postfix) with ESMTPS id B047389C37 for ; Tue, 12 Jan 2021 10:10:19 +0000 (UTC) Received: by mail-wm1-x334.google.com with SMTP id r4so1524573wmh.5 for ; Tue, 12 Jan 2021 02:10:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Bkg2PXaK2SWANw8IwP/AMIZLmCDZjaC0dDjfjSGMESw=; b=cxc3zmOOc8O4IH8V6hTkqvkq98jk+G0emPgAZJC4oEe9QTrnrtZqlQ7xqb+AWCjSWI 9/CkLrijkGHQKj73HYCupxLFnlL3Y8d+pLHhBschRr/rq048z7ric/I1xr8+8t7AXml5 a9v9NRGeeiONW1Cq3IFgq7Ul8aIgEKICYHmkG9N3hfUymD9i1L76tHGA5npX9IEkxyDA WkrP8L2n7ggp3PYaG/Wk8z2h1Kmnl/7q1Yof+15+CzeoQJ1gprctEBD/W3atO5hIirDg zt6HzVfEGQUSDK/rXiIVrXrORi+DKrMIE5Zt3uLM9BXa0vVM+s+UAHxPseo5esWwbBTT BcSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Bkg2PXaK2SWANw8IwP/AMIZLmCDZjaC0dDjfjSGMESw=; b=JL0jJcRs7SLiYwyp5TWVdYvzvISUDhPkBd49K2FJlWXVfnSFSuvrvHYyKUdGRwSVZX WoTiN+wTEOkqdKdirkBjX8wkZrc9lIsfe6zerdb0Yl8XXvRXuTZB8UTtErOs7Q4eWjXc YkmIjzkcfXYXUtBi/4Jsl5Ku35LAVPDHiBJ9UM9bhyz3yb1WqM7NdUGrE9LO4NpSXD0z XvaRELqG3QZwI9DhSOiq58vu1TVx8pgi95EVkYzzC2W0u8dQ9JO3elRkVYEiusJNMPeS VmjDgqf8wwl9fH9NaTYUjKNhJ93o3Fh0b5fsBl6Ce/U0ZSMJPyz39iQRJ8/mL3c5LZhW VlWg== X-Gm-Message-State: AOAM531GTtW4A2XSdNx29tLUcoCTdi3ufvpv4cRzTG604NFIa9gEomXQ WTRHvVfKMuAsrXn3L4z8EZ5T73sunh7+Qw== X-Google-Smtp-Source: ABdhPJxuWOHW4lhj241hPPbd10QF7Z7fViELfDVwFn+N7EUI4aG71W/c6XV/k326Dgsw7Hrg1Tl4fQ== X-Received: by 2002:a05:600c:2158:: with SMTP id v24mr2716731wml.129.1610446218465; Tue, 12 Jan 2021 02:10:18 -0800 (PST) Received: from smtp.gmail.com (a95-92-181-29.cpe.netcabo.pt. [95.92.181.29]) by smtp.gmail.com with ESMTPSA id s133sm3158707wmf.38.2021.01.12.02.10.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 02:10:17 -0800 (PST) Date: Tue, 12 Jan 2021 07:10:12 -0300 From: Melissa Wen To: Sumera Priyadarsini Subject: Re: [PATCH V5 2/3] drm/vkms: Add support for writeback module Message-ID: <20210112101012.a6mjwhtmtj3k34wt@smtp.gmail.com> References: <15802da4f1cdfed2b728c3d35731732f161dd073.1610391685.git.sylphrenadin@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <15802da4f1cdfed2b728c3d35731732f161dd073.1610391685.git.sylphrenadin@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hamohammed.sa@gmail.com, rodrigosiqueiramelo@gmail.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 01/12, Sumera Priyadarsini wrote: > Add enable_writeback feature to vkms_config as a module. > > Signed-off-by: Sumera Priyadarsini > --- > drivers/gpu/drm/vkms/vkms_drv.c | 5 +++++ > drivers/gpu/drm/vkms/vkms_drv.h | 1 + > drivers/gpu/drm/vkms/vkms_output.c | 9 ++++++--- > 3 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c > index 6b33975a5cb2..708f7f54001d 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.c > +++ b/drivers/gpu/drm/vkms/vkms_drv.c > @@ -40,6 +40,10 @@ static bool enable_cursor = true; > module_param_named(enable_cursor, enable_cursor, bool, 0444); > MODULE_PARM_DESC(enable_cursor, "Enable/Disable cursor support"); > > +static bool enable_writeback = true; > +module_param_named(enable_writeback, enable_writeback, bool, 0444); > +MODULE_PARM_DESC(enable_writeback, "Enable/Disable writeback connector support"); > + > DEFINE_DRM_GEM_FOPS(vkms_driver_fops); > > static void vkms_release(struct drm_device *dev) > @@ -189,6 +193,7 @@ static int __init vkms_init(void) > default_config = config; > > config->cursor = enable_cursor; > + config->writeback = enable_writeback; > > return vkms_create(config); > } > diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h > index 6a27bd8875f2..b9b4e2bc11c0 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.h > +++ b/drivers/gpu/drm/vkms/vkms_drv.h > @@ -83,6 +83,7 @@ struct vkms_output { > struct vkms_device; > > struct vkms_config { > + bool writeback; > bool cursor; > /* only set when instantiated */ > struct vkms_device *dev; > diff --git a/drivers/gpu/drm/vkms/vkms_output.c b/drivers/gpu/drm/vkms/vkms_output.c > index 8f3ffb28b9d1..f5f6f15c362c 100644 > --- a/drivers/gpu/drm/vkms/vkms_output.c > +++ b/drivers/gpu/drm/vkms/vkms_output.c > @@ -41,6 +41,7 @@ int vkms_output_init(struct vkms_device *vkmsdev, int index) > struct drm_crtc *crtc = &output->crtc; > struct drm_plane *primary, *cursor = NULL; > int ret; > + int writeback; > > primary = vkms_plane_init(vkmsdev, DRM_PLANE_TYPE_PRIMARY, index); > if (IS_ERR(primary)) > @@ -80,9 +81,11 @@ int vkms_output_init(struct vkms_device *vkmsdev, int index) > goto err_attach; > } > > - ret = vkms_enable_writeback_connector(vkmsdev); > - if (ret) > - DRM_ERROR("Failed to init writeback connector\n"); > + if (vkmsdev->config->writeback) { > + writeback = vkms_enable_writeback_connector(vkmsdev); > + if (writeback) > + DRM_ERROR("Failed to init writeback connector\n"); > + } Thanks, Reviewed-by: Melissa Wen > > drm_mode_config_reset(dev); > > -- > 2.25.1 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel