Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4683C433E0 for ; Wed, 13 Jan 2021 02:00:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A355C23117 for ; Wed, 13 Jan 2021 02:00:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726562AbhAMCAo (ORCPT ); Tue, 12 Jan 2021 21:00:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbhAMCAo (ORCPT ); Tue, 12 Jan 2021 21:00:44 -0500 Received: from bedivere.hansenpartnership.com (bedivere.hansenpartnership.com [IPv6:2607:fcd0:100:8a00::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFB62C061575; Tue, 12 Jan 2021 18:00:03 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id 053E71280302; Tue, 12 Jan 2021 18:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1610503202; bh=f1Dnw4/nY9A1kP44Bb2C0wMMkXBagHIrPgNeC3Jtk9U=; h=From:To:Subject:Date:Message-Id:From; b=lJqkMHvI2Iv0pt9dGdd3gIE05uaTodEtlh15AG+ghr7+6YlWFsFdzKnknIk+PplYW PnNaUzXUWczRBgXa08cTKW9BkgkDFO+AGPD7RX7bQH5IUVpoHhaOUY1Oh8k5o6zLhD SVTz9Luw4U/Gv9SVx1uZazCkkWlwt6DGOTrnVaDY= Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6Vvr8-p4Felp; Tue, 12 Jan 2021 18:00:01 -0800 (PST) Received: from jarvis.int.hansenpartnership.com (jarvis.ext.hansenpartnership.com [153.66.160.226]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id 9BD4B1280300; Tue, 12 Jan 2021 18:00:01 -0800 (PST) From: James Bottomley To: linux-integrity@vger.kernel.org Cc: Mimi Zohar , Jarkko Sakkinen , linux-api@vger.kernel.org Subject: [PATCH v5 0/1] add sysfs exports for TPM 2 PCR registers Date: Tue, 12 Jan 2021 17:59:57 -0800 Message-Id: <20210113015958.6685-1-James.Bottomley@HansenPartnership.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org This represents v5 which has the spelling mistake fixed and the WARN on unrecognized TPM hash algorithm becoming a dev_err. We've had a fairly extensive discussion and iterated to agreement on the output format, which becomes our ABI being one single compact hex representation of the hash value per file according to sysfs rules, with the file hierarchy going under /sys/class/tpm/tmp/pcr-/ So to get the value of PCR 7 in the sha256 bank of the default TPM I'd do cat /sys/class/tpm/tpm0/pcr-sha256/7 2ED93F199692DC6788EFA6A1FE74514AB9760B2A6CEEAEF6C808C13E4ABB0D42 If you need the binary hash of a set of PCRs, as is required for TPM policy statements that lock to PCRs, you'd use something like: cat /sys/class/tpm/tpm0/pcr-sha256/{1,6,7}|xxd -r -p|sha256sum Which produces the binary hash of PCRs 1, 6 and 7 in that order. Note that this patch also adds the sha1 bank for TPM 1.2 in the same manner (one file per PCR) but does not remove the existing pcrs file which has the space separated all PCRs in one file format of PCR-00: 7D 29 CB 08 0C 0F C4 16 7A 0E 9A F7 C6 D3 97 CD C1 21 A7 69 PCR-01: 9C B6 79 4C E4 4B 62 97 4C AB 55 13 1A 2F 7E AE 09 B3 30 BE ... James --- James Bottomley (1): tpm: add sysfs exports for all banks of PCR registers drivers/char/tpm/tpm-sysfs.c | 179 +++++++++++++++++++++++++++++++++++ include/linux/tpm.h | 9 +- 2 files changed, 187 insertions(+), 1 deletion(-) -- 2.26.2