Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA4F7C433DB for ; Wed, 13 Jan 2021 13:10:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97DC123433 for ; Wed, 13 Jan 2021 13:10:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726777AbhAMNKP (ORCPT ); Wed, 13 Jan 2021 08:10:15 -0500 Received: from mx2.suse.de ([195.135.220.15]:51052 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726729AbhAMNKP (ORCPT ); Wed, 13 Jan 2021 08:10:15 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E4CFAAB92; Wed, 13 Jan 2021 13:09:33 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id A4E091E0872; Wed, 13 Jan 2021 14:09:33 +0100 (CET) Date: Wed, 13 Jan 2021 14:09:33 +0100 From: Jan Kara To: Paolo Valente Cc: Jan Kara , linux-block@vger.kernel.org, Andreas Herrmann Subject: Re: [PATCH 1/2] bfq: Fix check detecting whether waker queue should be selected Message-ID: <20210113130933.GE6854@quack2.suse.cz> References: <20200409170915.30570-1-jack@suse.cz> <20200409170915.30570-2-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sun 10-01-21 10:20:22, Paolo Valente wrote: > > > > Il giorno 9 apr 2020, alle ore 19:09, Jan Kara ha scritto: > > > > The check in bfq_select_queue() checking whether a waker queue should be > > selected has a bug and is checking bfqq->next_rq instead of > > bfqq->waker_bfqq->next_rq to verify whether the waker queue has a > > request to dispatch. This often results in the condition being false > > (most notably when the current queue is idling waiting for next request) > > and thus the waker queue logic is ineffective. Fix the condition. > > > > Hi Jan, > my huge delay causes problems again, because a student of mine already > made this same fix a few months ago. But I did not send it out yet, > for lack of time. If ok for you, we could go for a common commit with > two authors (I seem to remember it is feasible). No problem for me. Or just give the student a credit instead of me. A commit in the kernel is likely more interesting for him than for me ;) Just reply to the v2 series I've sent today (you should be on CC) so that Jens knows the author should be changed. Honza -- Jan Kara SUSE Labs, CR