Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kznXc-00053P-RW for mharc-qemu-trivial@gnu.org; Wed, 13 Jan 2021 16:18:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kznUr-0003Kx-GB for qemu-trivial@nongnu.org; Wed, 13 Jan 2021 16:16:05 -0500 Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]:34691) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kznUp-0008Ly-Ig for qemu-trivial@nongnu.org; Wed, 13 Jan 2021 16:16:05 -0500 Received: by mail-qk1-x730.google.com with SMTP id c7so4142175qke.1 for ; Wed, 13 Jan 2021 13:16:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spacecodesign.com; s=google; h=from:to:cc:subject:date:message-id; bh=/+0KbUs6wv+H6He8aUZqbucCfLiVDvi1h7YFTS+o9Lc=; b=BdlJHEAZd/zaxamzIA8LckuaRtz0wBOoGynDz1WLVypSO4ffOS3K00apPBfpR5Xdi8 UnImOsFr4SdKFcuMTcsluQi2KVytzI7AqDWTwk8dDhCeGNGVtqKuGfknjFutikHObt+5 91O2Ik3FfIv1M+vsvKCYQJk/pKPesiaOZlGDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=/+0KbUs6wv+H6He8aUZqbucCfLiVDvi1h7YFTS+o9Lc=; b=LqHSV2sX8kPWbbiUVK3mbwue1QGLmWyBCvsV0FYchZkqMONvGq4let6fM5x7qogpoH wGv+vVgUQovNnntEpTpe9n8eEqy1xQBTRNFpC6pBRaz2iUV+kTXin/CABfAfJAiriLCV esoaBVtk/WTYVp/aFa+zVcRwfSJrS8DyFAWp2SXD8KZFhfLPCoo7YCYlkHLCQ9OoIp8p XecUDrCZFBpAaR7BuS8UA2ViNlR5Sv3/pQU6KvjfJpAc/XwSe/WCHSzBwq/+l9Tr/by/ Wz4OALfbDulOrwXBWNjDGkTr+tYF3M19FHpKmdtK/8ZtvR4wjQR7dtZOhhUtzXVb/16P OV3A== X-Gm-Message-State: AOAM531XTi7Q+voCVph8xLyegJOCwdzY5viEuse78zeK50hRFmfc16zG l1uKJZhCXE5oVgUn4dl1Y9exDw== X-Google-Smtp-Source: ABdhPJxUyuAMYTAzbKzq+6PhD1lj3CBFsMYO2x+Pueno4Yyop3VUf65tlasaBPAOg+a9N/h6LC2vXw== X-Received: by 2002:a37:a14a:: with SMTP id k71mr3985273qke.33.1610572562349; Wed, 13 Jan 2021 13:16:02 -0800 (PST) Received: from localhost.localdomain (104-37-205-141.resi.cgocable.ca. [104.37.205.141]) by smtp.gmail.com with ESMTPSA id o201sm1869321qke.60.2021.01.13.13.16.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Jan 2021 13:16:01 -0800 (PST) From: Anthony Dentinger To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Anthony Dentinger Subject: [PATCH] hw/char/cadence_uart: Fixed wrong Cadence UART stop bit count register value. Date: Wed, 13 Jan 2021 16:15:31 -0500 Message-Id: <20210113211531.20696-1-anthony.dentinger@spacecodesign.com> X-Mailer: git-send-email 2.16.2.windows.1 Received-SPF: pass client-ip=2607:f8b0:4864:20::730; envelope-from=anthony.dentinger@spacecodesign.com; helo=mail-qk1-x730.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 13 Jan 2021 16:18:55 -0500 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2021 21:16:05 -0000 Here is a reference showing that 0x00 is the correct value: - https://www.xilinx.com/support/documentation/user_guides/ug585-Zynq-7000-TRM.pdf (page 1776, Register XUARTPS_MR_OFFSET Details, which is for a platform called Zynq that has a UART made by Cadence) - https://github.com/Xilinx/linux-xlnx/blob/51445f9139af73c616f054a8fcc77ed2568b81b1/drivers/tty/serial/xilinx_uartps.c#L98 (Linux driver for the Cadence UART on that Zynq platform). Signed-off-by: Anthony Dentinger --- hw/char/cadence_uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c index c603e14012..a049ed50c4 100644 --- a/hw/char/cadence_uart.c +++ b/hw/char/cadence_uart.c @@ -93,7 +93,7 @@ #define UART_DATA_BITS_7 (0x2 << UART_MR_CHRL_SH) #define UART_PARITY_ODD (0x1 << UART_MR_PAR_SH) #define UART_PARITY_EVEN (0x0 << UART_MR_PAR_SH) -#define UART_STOP_BITS_1 (0x3 << UART_MR_NBSTOP_SH) +#define UART_STOP_BITS_1 (0x0 << UART_MR_NBSTOP_SH) #define UART_STOP_BITS_2 (0x2 << UART_MR_NBSTOP_SH) #define NORMAL_MODE (0x0 << UART_MR_CHMODE_SH) #define ECHO_MODE (0x1 << UART_MR_CHMODE_SH) -- 2.16.2.windows.1