Content-Type: multipart/mixed; boundary="===============0644073203412796982==" MIME-Version: 1.0 From: Sergey Matyukevich Subject: [PATCH v2] sim: validate IMS private identity Date: Fri, 15 Jan 2021 22:56:35 +0300 Message-ID: <20210115195635.26791-1-geomatsi@gmail.com> List-Id: To: ofono@ofono.org --===============0644073203412796982== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Make sure that IMS private identity is a valid UTF8 string before setting sim->impi field. Otherwise ofono may crash on dbus assert when SIM properties are reported via org.ofono.SimManager interface. --- src/sim.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/sim.c b/src/sim.c index 33e1245f..2a663e2d 100644 --- a/src/sim.c +++ b/src/sim.c @@ -1664,7 +1664,8 @@ static void impi_read_cb(int ok, int total_length, in= t record, return; } = - sim->impi =3D g_strndup((const char *)data + 2, data[1]); + if (g_utf8_validate((const char *)data + 2, data[1], NULL)) + sim->impi =3D g_strndup((const char *)data + 2, data[1]); } = static void discover_apps_cb(const struct ofono_error *error, --===============0644073203412796982==--