From: Pali =?utf-8?B?Um9ow6Fy?= Date: Sat, 16 Jan 2021 01:18:51 +0100 Subject: [PATCH 02/13] usb: musb: Fix compilation of gadget code In-Reply-To: <20201129175212.GD27274@amd> References: <20201129164618.5829-1-pali@kernel.org> <20201129164618.5829-3-pali@kernel.org> <20201129175212.GD27274@amd> Message-ID: <20210116001851.vzked4mxvoonouho@pali> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sunday 29 November 2020 18:52:13 Pavel Machek wrote: > On Sun 2020-11-29 17:46:07, Pali Roh?r wrote: > > musb udc code depends on usb gadget code provided by CONFIG_USB_DEVICE and > > defined in drivers/usb/gadget/Makefile. But this Makefile is not included > > into U-Boot build when CONFIG_USB_GADGET is not set. As CONFIG_USB_DEVICE > > cannot be enabled together with CONFIG_USB_GADGET it means that dependency > > for musb udc code is not compiled during build. Fix it by including > > drivers/usb/gadget dependency also when CONFIG_USB_DEVICE is set. > > > _device_event_irq' > > arm-linux-gnueabi-ld.bfd: drivers/usb/musb/built-in.o:u-boot/drivers/usb/musb/musb_udc.c: more undefined references to `usbd_device_event_irq' follow > > arm-linux-gnueabi-ld.bfd: drivers/usb/musb/built-in.o: in function `udc_setup_ep': > > u-boot/drivers/usb/musb/musb_udc.c: undefined reference to `usbd_alloc_urb' > > arm-linux-gnueabi-ld.bfd: drivers/usb/musb/built-in.o: in function `udc_startup_events': > > u-boot/drivers/usb/musb/musb_udc.c: undefined reference to `usbd_device_event_irq' > > arm-linux-gnueabi-ld.bfd: u-boot/drivers/usb/musb/musb_udc.c: undefined reference to `usbd_device_event_irq' > > arm-linux-gnueabi-ld.bfd: u-boot/drivers/usb/musb/musb_udc.c: undefined reference to `usbd_device_event_irq' > > make: *** [Makefile:1762: u-boot] Error 1 > > > > Signed-off-by: Pali Roh?r > > Reviewed-by: Pavel Machek PING! I would like to remind this patch series as above compile error is still present in U-Boot v2021.01 version.