From: Tom Rini Date: Sat, 16 Jan 2021 11:25:00 -0500 Subject: [PATCH v3 6/9] IOMUX: Preserve console list if realloc() fails In-Reply-To: <20201221123008.9930-6-andriy.shevchenko@linux.intel.com> References: <20201221123008.9930-1-andriy.shevchenko@linux.intel.com> <20201221123008.9930-6-andriy.shevchenko@linux.intel.com> Message-ID: <20210116162500.GV9782@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Dec 21, 2020 at 02:30:05PM +0200, Andy Shevchenko wrote: > It's realloc() 101 to avoid `foo = realloc(foo, ...);` call > due to getting a memory leak. > > Actually it's not clear why realloc() has been used here. > If we shrink the array, the memcpy() overwrites it anyway > with the contents of a new array. If it becomes bigger, > same story. > > Drop useless realloc() for good and thus preserve console list > in case of failed allocation. > > Fixes: 16a28ef219c2 ("IOMUX: Add console multiplexing support.") > Signed-off-by: Andy Shevchenko > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: